add support for sphinxcontrib-video #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support to process video nodes and publish assets to Confluence. sphinxcontrib-video - https://github.com/sphinx-contrib/video Signed-off-by: Aleksandr Musorin <aleksandr.musorin@semrush.com>
jdknight
reviewed
Jun 10, 2023
There was a problem hiding this comment.
This would be a nice addition; thanks for taking the time for setting up the pull request (and the documentation/test updates 🙇).
I added one comment with respect to height/width processing (if it's an issue), but other than that, it looks good. Feel free to ignore any optional comments.
A series of additional changes have been made to this initial implementation provided by the community: - Provide support for width/height unit support, if ever provided by the third-party extension. - Adjust sample set to show example of autoplay (which works for some browsers; autoplay can be restricted by a client and not controllable by this extension). - Update video to another sample which included audio. - Sort/tweak the implementation to match the rest of the implementation. Signed-off-by: James Knight <james.d.knight@live.com>
|
Had time and was able to adjust the review suggestions. Thanks for the contribution to support this new third-party extension. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support to process video nodes and publish assets to Confluence.
sphinxcontrib-video - https://github.com/sphinx-contrib/video