Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[version-4-2] backport Windows node pool PR 2130 #2407

Merged
merged 1 commit into from
Mar 14, 2024
Merged

[version-4-2] backport Windows node pool PR 2130 #2407

merged 1 commit into from
Mar 14, 2024

Conversation

caroldelwing
Copy link
Contributor

@caroldelwing caroldelwing commented Mar 14, 2024 •
edited
Loading

Describe the Change

This PR addresses the backport issues with PR #2130.

Changed Pages

💻 Deploy Windows Workloads

Backports

Can this PR be backported?

  • Yes. Remember to add the relevant backport labels to your PR.
  • No. Please leave a short comment below about why this PR cannot be backported. This is a backport PR.

@liltigermel @caroldelwing @yuliiiah
Windows node pool (#2130)
441e2e4 
* added windows [age for AKS

* added windows page for AKS

* added windows page for AKS1

* docs: fix broken links

* docs: vale and style guide

* docs: vale suggestions

* docs: fix typos, last review

* docs: fix link

* docs: address suggestions

* Apply suggestions from code review

Co-authored-by: Yuliia Horbenko <31223054+yuliiiah@users.noreply.github.com>

* docs: add more suggestions

* docs: fix wrong links

* docs: highlight manifest

---------

Co-authored-by: Melody Hazi <melodyhazi@Melodys-MacBook-Pro.local>
Co-authored-by: Carolina Delwing Rosa <carolina.delwing@spectrocloud.com>
Co-authored-by: Yuliia Horbenko <31223054+yuliiiah@users.noreply.github.com>
@netlify Netlify
Copy link

netlify bot commented Mar 14, 2024 •
edited
Loading

✅ Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 441e2e4
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/65f30b0a5a603e00081cc2a5
😎 Deploy Preview https://deploy-preview-2407--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@caroldelwing caroldelwing marked this pull request as ready for review March 14, 2024 14:37
@caroldelwing caroldelwing requested a review from a team as a code owner March 14, 2024 14:37
@caroldelwing caroldelwing requested review from karl-cardenas-coding, yuliiiah and lennessyy and removed request for a team March 14, 2024 14:37
@caroldelwing caroldelwing merged commit 0d23d59 into version-4-2 Mar 14, 2024
5 checks passed
@caroldelwing caroldelwing deleted the backport-windows-4-2 branch March 14, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karl-cardenas-coding karl-cardenas-coding Awaiting requested review from karl-cardenas-coding karl-cardenas-coding is a code owner automatically assigned from spectrocloud/docs-education

@yuliiiah yuliiiah Awaiting requested review from yuliiiah yuliiiah is a code owner automatically assigned from spectrocloud/docs-education

@lennessyy lennessyy Awaiting requested review from lennessyy lennessyy is a code owner automatically assigned from spectrocloud/docs-education

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caroldelwing @liltigermel