refactor(tools): use fs.promises API

[saschanaz]

Uses fs.promises which is now marked as stable.

[sidvishnoi]

We can remove fs-extra from package.json now, right?

[saschanaz]

copydeps still uses fs-extra for its own utility functions, but maybe we could cook our own ones.

[sidvishnoi]

I checked. cp is being used only for files (not directories), so we can use the native one easily. And we have fs.rmdir and fs.unlink for fsp.remove 🎉

[sidvishnoi]

@saschanaz Do you plan to fix above here or separate PR?

[saschanaz]

Hmm, maybe a separate one.

[sidvishnoi]

Should we update this too?
https://github.com/w3c/respec/blob/2c073773d343e3a93196ad20307d5508a3df83d0/package.json#L7

[saschanaz]

Should we update this too?

Ah yes... but should we defer this until version 8 loses its support? Not sure.

[sidvishnoi]

fs.promises isn't available in node 8, right? It'll break if use node 11 features there

[saschanaz]

The API is introduced in Node.js 10, but yes, it will break 8.

[marcoscaceres]

This is in node lts, right?

[saschanaz]

This is in node lts, right?

Sure 😃

[marcoscaceres]

We should target active lts only. Ok to delete 8.

[saschanaz]

One notable thing is that nodejs/node#26581 is not backported into 10 LTS yet, so using ReSpec there may emit some warnings.

[saschanaz]

is not backported into 10 LTS yet, so using ReSpec there may emit some warnings.

Like this... Looks like we should wait a bit more 😅

6:50:21 AM  ⏲  Running ReSpec2html tests...
6:50:21 AM  👷‍♀️  node ./tools/respec2html.js -e --disable-sandbox --timeout 30 --src http://localhost:5000/examples/basic.built.html --out /dev/null (test 1/2)
(node:4775) ExperimentalWarning: The fs.promises API is experimental
6:50:22 AM  👷‍♀️  node ./tools/respec2html.js -e --disable-sandbox --timeout 30 --src http://localhost:5000/examples/basic.html --out /dev/null (test 2/2)
(node:4838) ExperimentalWarning: The fs.promises API is experimental
The command "npm run test:headless" exited with 0.

[sidvishnoi]

Lets pipe it through grep -v "ExperimentalWarning: The fs.promises API is experimental" 😛

[marcoscaceres]

The warnings are ok IMO. Reading the history, the API did not change from when it was experimental to when it became stable... so technically, it was stable. Also, the warning don’t affect processing, so I think it’s fine to ship.