Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update quickstart documentation #1701

Merged
merged 7 commits into from
May 9, 2023
Merged

Update quickstart documentation #1701

merged 7 commits into from
May 9, 2023

Conversation

RobbeSneyders
Copy link
Member

Contributes towards #1531

Updates the quickstart documentation for v3. I removed some more detailed stuff that I don't think belongs on this page.

@RobbeSneyders RobbeSneyders added this to the Connexion 3.0 milestone Apr 29, 2023
@RobbeSneyders RobbeSneyders mentioned this pull request May 2, 2023
Closed
@coveralls
Copy link

coveralls commented May 2, 2023 •
edited
Loading

Coverage Status

Coverage: 94.042%. Remained the same when pulling d049ef7 on feature/docs-quickstart into 15fe2ed on main.

@Ruwann Ruwann linked an issue May 9, 2023 that may be closed by this pull request
Typo in middleware.main #1696
Closed
Ruwann
Ruwann approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@Ruwann Ruwann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice in the preview! Some minor additions and questions, but looks very nice in general with the different tabs

connexion/middleware/main.py
"""
Register a callable to handle application errors.

:param code_or_exception: An exception class or the status code of HTTP exceptions to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exceptions --> singular?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think plural works best here

connexion/apps/flask.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
docs/conf.py Show resolved Hide resolved
docs/quickstart.rst Show resolved Hide resolved
Ruwann
Ruwann reviewed May 9, 2023
View reviewed changes
docs/index.rst Outdated Show resolved Hide resolved
@RobbeSneyders RobbeSneyders merged commit 0c0c517 into main May 9, 2023
@RobbeSneyders RobbeSneyders deleted the feature/docs-quickstart branch May 9, 2023 20:22
@RobbeSneyders RobbeSneyders mentioned this pull request May 9, 2023
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ruwann Ruwann Ruwann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Connexion 3.0
Development

Successfully merging this pull request may close these issues.

Typo in middleware.main
3 participants
@RobbeSneyders @coveralls @Ruwann