Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API with base path not reachable when registered after API without base path. #1709

Closed
RobbeSneyders opened this issue Jun 6, 2023 · 0 comments · Fixed by #1716
Closed

API with base path not reachable when registered after API without base path. #1709

RobbeSneyders opened this issue Jun 6, 2023 · 0 comments · Fixed by #1716
Assignees
@Ruwann

Comments

@RobbeSneyders
Copy link
Member

Description

When registering multiple APIS, where the base path of a later API contains the base path of the earlier API, the later API is not accessible. Eg:

app = connexion.FlaskApp(__name__, specification_dir="spec/")
app.add_api("openapi.yaml", base_path="/")
app.add_api("swagger.yaml", base_path="/swagger")

We can fix this by sorting the APIs on their base path before registering them, which we do here.
@Ruwann Ruwann self-assigned this Jun 16, 2023
@Ruwann Ruwann mentioned this issue Jun 16, 2023
Merged
@Ruwann Ruwann linked a pull request Jun 20, 2023 that will close this issue
Bugfix/basepath #1716
Merged
RobbeSneyders pushed a commit that referenced this issue Jul 1, 2023
@Ruwann
Bugfix/basepath (#1716)
3fa9f3b 
Working towards #1709 

I think we're almost there, some tests I did are now working properly.

Would love to get some feedback/ideas on the implementation and the
tests :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ruwann Ruwann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix/basepath Ruwann/connexion
2 participants
@RobbeSneyders @Ruwann