Fix Subscript literal evaluation for List #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add utest to track failing original code
alexnick83
requested changes
May 8, 2024
There was a problem hiding this comment.
Thank you! The fix is very good. Could you also add a test for tuples (see comments on code)? Currently, ast.List and ast.Tuple are very similar (both have elts), therefore, it makes sense to treat them both similarly. Furthermore, a test will be very useful if this changes in a future Python version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at: #1568
The code was blindly calling down to a
_visit_potential_constantwhich is written for single element rather collection of them. Unroll the list, like thedictis done in theifabove.