Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule tree (1/3) #1145

Merged
merged 108 commits into from
Sep 26, 2023
Merged

Schedule tree (1/3) #1145

merged 108 commits into from
Sep 26, 2023

Conversation

tbennun
Copy link
Collaborator

@tbennun tbennun commented Nov 8, 2022

(re)scheduling oriented view of SDFGs.
Task list:

  • De-aliasing across nested SDFGs
    • Arrays and memlets (use compose)
    • Memlets and symbols in control flow blocks
    • Symbol assignments
      • (low-prio: think about C++ tasklets, or error out / replace if \bNAME\b is used?)
  • Normalize memlets everywhere (data / subset / other_subset)
    • Copy
      • If both exist, write as dst[dst_subset] = copy src[src_subset]
    • View
  • Dynamic map ranges (also with aliasing)
  • Ensure memlet paths are not generated twice
  • Duplicate label removal (also consider states in different SDFGs that share the same name!)
  • Make many tests
    • Irreducible CFGs
    • Memlet path types
      • same scope
      • multi-scope (3 nested maps)
      • through nested SDFG
      • differing src/dst subsets: same scope
      • differing src/dst subsets: inside map
      • offsetted
    • Nesting and (de)aliasing
      • Call nested(a[0:20], a[10:30])
      • prog(a, b), nested(b, c)
      • Composition: a[:, 1] -> b[-5:] -> c[2]
      • Control flow blocks with same variables in nested SDFGs
    • Code->code memlets
    • Dynamic map ranges
    • References
    • Naming clashes (n: m, m: n symbol mapping, different states with same name etc.)

tbennun and others added 30 commits November 8, 2022 14:37
… SDFG. Added methods for printing pseudo-DaCe-Python code. Updated the `as_schedule_tree` method to unsqueeze memlets and rename arrays to match the names in the top-level SDFG.
@tbennun tbennun removed the no-ci Do not run any CI or actions for this PR label Sep 24, 2023
@tbennun tbennun marked this pull request as ready for review September 25, 2023 00:25
Copy link
Collaborator

@phschaad phschaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very excited about this PR, thank you! Small questions and revisions/changes, largely LGTM 🎉

dace/sdfg/replace.py Show resolved Hide resolved
dace/sdfg/nodes.py Show resolved Hide resolved
dace/sdfg/sdfg.py Outdated Show resolved Hide resolved
dace/sdfg/analysis/schedule_tree/treenodes.py Outdated Show resolved Hide resolved
dace/sdfg/analysis/schedule_tree/treenodes.py Outdated Show resolved Hide resolved
dace/sdfg/analysis/schedule_tree/passes.py Outdated Show resolved Hide resolved
dace/sdfg/analysis/schedule_tree/sdfg_to_tree.py Outdated Show resolved Hide resolved
dace/sdfg/memlet_utils.py Outdated Show resolved Hide resolved
tests/sdfg/memlet_utils_test.py Outdated Show resolved Hide resolved
dace/sdfg/memlet_utils.py Show resolved Hide resolved
@tbennun tbennun enabled auto-merge (squash) September 26, 2023 16:18
@tbennun tbennun merged commit a582261 into master Sep 26, 2023
9 checks passed
@tbennun tbennun deleted the schedule-tree branch September 28, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants