New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and update docs #25

Merged

freekmurze merged 3 commits into spatie:main from choowx:update-docs

May 21, 2023

Contributor

choowx commented May 20, 2023

This PR makes 3 changes to the code examples in the docs.

Fix incorrect parameters used in addIf method.
Corrects the 2nd and 3rd arguments to be title and url respectively. Additionally, it ensures that the configure callback is placed as the 4th parameter, and the callback now receives a Section instance instead of a Navigation instance.
Populate missing attributes and depth to the array outputs.
Simplified the usage by utilizing arrow functions in the callbacks.

Feel free to share your thoughts and review.😄

choowx added 3 commits

May 20, 2023 14:34


          Fix incorrect code example in docs.

56a1c1a


          Fill missing attributes and depth to example array output in docs.

ac83da1


          Use arrow functions in code example's callback in docs.

8efeb63

freekmurze merged commit 31e2e32 into spatie:main

Member

freekmurze commented May 21, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet