Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix quality config parameter #219

Merged
merged 2 commits into from
May 16, 2024
Merged

Fix quality config parameter #219

merged 2 commits into from
May 16, 2024

Conversation

0xb4lint
Copy link
Contributor

configHasOptimizer() method fix with test

Fixes #218.

glye
glye approved these changes May 16, 2024
View reviewed changes
Copy link

@glye glye left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix! This resolves the issue for us.

@freekmurze freekmurze merged commit d710967 into spatie:main May 16, 2024
13 checks passed
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glye glye glye approved these changes

@webhdx webhdx webhdx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OptimizerChainFactory refactoring broke "quality" config
4 participants
@0xb4lint @freekmurze @glye @webhdx