Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suppress ruby 2.7 valgrind errors #1938

Closed
flavorjones opened this issue Oct 29, 2019 · 2 comments
Closed

suppress ruby 2.7 valgrind errors #1938

flavorjones opened this issue Oct 29, 2019 · 2 comments
Labels
topic/ci topic/memory Segfaults, memory leaks, valgrind testing, etc.

Comments

@flavorjones
Copy link
Member

Suppress Ruby 2.7 valgrind errors.

See https://ci.nokogiri.org/teams/nokogiri-core/pipelines/nokogiri/jobs/ruby-2.7-rc-valgrind/builds/1 for examples.

We've had to do this for previous versions of Ruby as well, see the /suppressions subdirectory.
@flavorjones
Copy link
Member Author

Also - make sure these suppressions gets merged into the v1.10.x branch for the next patch release, see https://ci.nokogiri.org/teams/nokogiri-core/pipelines/nokogiri-v1.10.x/jobs/ruby-2.7-rc-valgrind/builds/1

flavorjones added a commit that referenced this issue Oct 29, 2019
@flavorjones
add suppressions for ruby 2.7
fa7845a 
related to #1938
flavorjones added a commit that referenced this issue Oct 29, 2019
@flavorjones
add suppressions for ruby 2.7
2a86496 
related to #1938
@flavorjones
Copy link
Member Author

Re-running CI:

All green.

flavorjones added a commit that referenced this issue Oct 29, 2019
@flavorjones
add suppression for ruby 2.7
492e266 
related to #1938
@flavorjones flavorjones added the topic/memory Segfaults, memory leaks, valgrind testing, etc. label Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic/ci topic/memory Segfaults, memory leaks, valgrind testing, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@flavorjones