Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commands for some powersave modes #189

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

hybridOL
Copy link

@hybridOL hybridOL commented Apr 1, 2023

These config commands were not yet supported. They cover two of the power save commands with their full functionality. Enums for the parameters have been created.
Moreover, one more getter function for psm state in PVT flags has been added.

@PaulZC
Copy link
Collaborator

PaulZC commented Apr 3, 2023

Hi @hybridOL ,

Thank you for submitting this pull request too. The new code looks good and I will merge it into the next release.

The library already contains a powerSaveMode method, but it includes an additional protocol version check which slows it down. I will update powerSaveMode to use setRXM internally.

// Power Save Mode
// Enables/Disables Low Power Mode using UBX-CFG-RXM
bool SFE_UBLOX_GNSS::powerSaveMode(bool power_save, uint16_t maxWait)

Also I will change the names, just to make them more self-explanatory: setRXM -> setPowerManagement, setPMS -> setupPowerMode.

Best wishes,
Paul

@PaulZC
Copy link
Collaborator

PaulZC commented Oct 9, 2023

Hi @hybridOL ,

Apologies for the delay!!

Merging...

Many thanks,
Paul

@PaulZC PaulZC merged commit abffe1a into sparkfun:release_candidate Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants