-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dace: Add package and version 0.15.1 #36178
Conversation
Hi @tbennun! I noticed that the following package(s) don't yet have maintainers:
Are you interested in adopting any of these package(s)? If so, simply add the following to the package class: maintainers("tbennun") If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with $ spack blame py-dace Thank you for your help! Please don't add maintainers without their consent. You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed the affected version sha256 for the two packages and the branch for py-dace.
@adamjstewart I fixed all the dependencies (and added ones that were on setup.py but not on Spack). Wherever there is a difference, I pointed it out with comments. This is ready for re-review on my end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question, otherwise LGTM
@adamjstewart Thank you for the thorough review! I think I addressed all the comments now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last comment is optional, let me know if you just want me to merge.
@adamjstewart fixed, thank you for noticing! I think it’s ready for merging |
@spackbot run pipeline |
I've started that pipeline for you! |
* dace: Add package and version 0.14.2 * Update dependencies and package version * Address review comments * Style * Address review comments * Address review comments
* dace: Add package and version 0.14.2 * Update dependencies and package version * Address review comments * Style * Address review comments * Address review comments
* dace: Add package and version 0.14.2 * Update dependencies and package version * Address review comments * Style * Address review comments * Address review comments
This PR adds the DaCe framework as
py-dace
. It also updatespy-aenum
to a newer version that DaCe requires in order to work.