Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dace: Add package and version 0.15.1 #36178

Merged
merged 7 commits into from
Jan 1, 2024
Merged

Conversation

tbennun
Copy link
Contributor

@tbennun tbennun commented Mar 16, 2023

This PR adds the DaCe framework as py-dace. It also updates py-aenum to a newer version that DaCe requires in order to work.

@spackbot-app
Copy link

spackbot-app bot commented Mar 16, 2023

Hi @tbennun! I noticed that the following package(s) don't yet have maintainers:

  • py-dace

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers("tbennun")

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame py-dace

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the affected version sha256 for the two packages and the branch for py-dace.

@tldahlgren tldahlgren self-assigned this Mar 16, 2023
@adamjstewart adamjstewart self-assigned this Mar 18, 2023
@tbennun tbennun changed the title dace: Add package and version 0.14.2 dace: Add package and version 0.15.1 Dec 18, 2023
@tbennun
Copy link
Contributor Author

tbennun commented Dec 18, 2023

@adamjstewart I fixed all the dependencies (and added ones that were on setup.py but not on Spack). Wherever there is a difference, I pointed it out with comments. This is ready for re-review on my end.

Copy link
Member

@becker33 becker33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, otherwise LGTM

becker33
becker33 previously approved these changes Dec 20, 2023
@tbennun
Copy link
Contributor Author

tbennun commented Dec 28, 2023

@adamjstewart Thank you for the thorough review! I think I addressed all the comments now.

adamjstewart
adamjstewart previously approved these changes Dec 31, 2023
Copy link
Member

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last comment is optional, let me know if you just want me to merge.

var/spack/repos/builtin/packages/py-dace/package.py Outdated Show resolved Hide resolved
@tbennun
Copy link
Contributor Author

tbennun commented Dec 31, 2023

@adamjstewart fixed, thank you for noticing! I think it’s ready for merging

@adamjstewart
Copy link
Member

@spackbot run pipeline

@adamjstewart adamjstewart enabled auto-merge (squash) January 1, 2024 14:40
Copy link

spackbot-app bot commented Jan 1, 2024

I've started that pipeline for you!

@adamjstewart adamjstewart merged commit db33124 into spack:develop Jan 1, 2024
13 checks passed
@tbennun tbennun deleted the py-dace branch January 1, 2024 15:09
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Jan 25, 2024
* dace: Add package and version 0.14.2

* Update dependencies and package version

* Address review comments

* Style

* Address review comments

* Address review comments
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Jan 31, 2024
* dace: Add package and version 0.14.2

* Update dependencies and package version

* Address review comments

* Style

* Address review comments

* Address review comments
kwryankrattiger pushed a commit to kwryankrattiger/spack that referenced this pull request Jul 9, 2024
* dace: Add package and version 0.14.2

* Update dependencies and package version

* Address review comments

* Style

* Address review comments

* Address review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants