Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable PytestUnraisableExceptionWarning errors due to #150 #160

Merged

Conversation

WilliamJamieson
Copy link
Contributor

I have seen several instances of the error from #150 come up in the CI. See #150 (comment). The CI log doesn't show the entire log, but I see the error if I watch the job and it occurs.

Since we are getting this flakiness due to the turning PytestUnraisableExceptionWarning into errors, I am disabling this feature for now. If anyone happens to notice such a warning output during their tests, please comment with your configuration on #150.

@WilliamJamieson WilliamJamieson requested a review from a team as a code owner April 19, 2023 17:55
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5087ffe) 96.73% compared to head (0a5f369) 96.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #160   +/-   ##
=======================================
  Coverage   96.73%   96.73%           
=======================================
  Files           9        9           
  Lines        1101     1101           
=======================================
  Hits         1065     1065           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WilliamJamieson WilliamJamieson merged commit c4290df into spacetelescope:main Apr 26, 2023
@WilliamJamieson WilliamJamieson deleted the bugfix/flaky_test branch April 26, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants