Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify datamodels test to not check for ASDF tree in ImageHDU #1600

Merged
merged 1 commit into from
Dec 15, 2017

Conversation

jdavies-st
Copy link
Collaborator

The storage of the ASDF tree in either an ImageHDU or another type of HDU is an ASDF implementation detail, and should not be tested here. This allows for the proposed change in ASDF PR 412 to put the ASDF tree in a NonstandardExtHDU instead of an ImageHDU.

@jdavies-st
Copy link
Collaborator Author

jdavies-st commented Dec 15, 2017

One further change in this PR is adding the .eggs directory in the repository to be ignored when running test. There's a corner case if you first run python setup.py test without having the test dependencies installed, it will install them in the .eggs/ subdir. Then if you later try to run pytest in the top level directory, it will try to run the tests inside the .eggs/ subdir, i.e. the tests in the package dependencies.

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jdavies-st jdavies-st merged commit 702066b into spacetelescope:master Dec 15, 2017
@jdavies-st jdavies-st deleted the remove_asdf_test branch March 15, 2018 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants