Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase asdf-wcs-schemas version #491

Merged
merged 5 commits into from
Mar 10, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Mar 9, 2024

asdf-wcs-schemas 0.4.0 was released.

This PR increases the minimum required version to 0.4.0.

As #488 is not yet released the changelog entry was updated to point to this PR.

Additionally this PR adds an upper pin for pytest (as a test dependency) as the newest version 8.1.1 is incompatible with pytest-doctestplus (see scientific-python/pytest-doctestplus#243). EDIT: a new version of pytest-doctestplus was released that fixed the issue

Finally, this PR also increases the minimum tested numpy to 1.23 (the oldest supported version at this time, see: https://numpy.org/neps/nep-0029-deprecation_policy.html#support-table).

@braingram braingram requested a review from a team as a code owner March 9, 2024 20:29
Copy link

codecov bot commented Mar 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.28%. Comparing base (eb9d316) to head (cdaa38a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #491   +/-   ##
=======================================
  Coverage   87.28%   87.28%           
=======================================
  Files          22       22           
  Lines        3821     3823    +2     
=======================================
+ Hits         3335     3337    +2     
  Misses        486      486           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nden nden merged commit 6c67a99 into spacetelescope:master Mar 10, 2024
23 checks passed
@braingram braingram deleted the asdf_wcs_bump branch March 10, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants