INDY-2102: change auth_map format #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
…lugin into story-2087-auth-rules
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
| @@ -81,4 +87,16 @@ def test_set_fees(helpers, | |||
| old_value='*', | |||
| new_value='*', | |||
| constraint=sovtokenfees_auth_map[edit_fees.get_action_id()].as_dict) | |||
| resp = sdk_get_auth_rule_request(looper, | |||
There was a problem hiding this comment.
I think it makes sense to rather update tests from sovtokenfees/sovtokenfees/test/test_get_auth_rule.py (which are almost copy-paste from Node),
There was a problem hiding this comment.
Moved this check in test_get_auth_rule for sovtokenfees, but didn't move it in sovtoken because there is not test_get_auth_rule.
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
ashcherbakov
approved these changes
May 23, 2019
lampkin-diet
approved these changes
May 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.