Allow override of global push settings

[devsibwarra]

We run multiple openvpn instances, some needing push_options that differ from the node[openvpn][push_options] value. This change allows overriding the global setting per-instance

Example

  openvpn_conf 'something' do
    action :create
    config ({
      'opt-verify' => '',
      'verb' => '4'
    })
    push_options ({
      'explicit-exit-notify' => '1',
      'route-gateway' => '10.8.0.1'
    })
  end

[flaccid]

@devsibwarra makes sense, thanks!

[devsibwarra]

Looking deeper into the LWRP code, I think the variable type for push_routes/push_options can be an Array or Hash.

Thoughts? I can send a new PR for this quick fix

[flaccid]

I noticed that too when I was reviewing; I think I was being a bit lazy due to being on holidays :)
Added a commit to make them Array. If you can find any issues, improvements or tests to add around this area, much appreciated.

[devsibwarra]

The example in README.md uses an Array for push_routes and a Hash for push_options, so at the very least I'd suggest making the latter allow both ([Array,Hash])

[flaccid]

It's actually an array of strings or hashes, the value depends on the directive you are setting and is relevant to how it is rendered (https://github.com/xhost-cookbooks/openvpn/blob/master/providers/conf.rb#L34-L51). The actual attribute is an array at that level. In the template, we do <% render_push_options(@push_options).each do |line| -%>.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.