Allow docker_container memory to have String value (eg. memory='1G'). #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! I'm sure a lot of people will appreciate this. Hopefully not too many folks using swap functionality. 😉 |
bflad
added a commit
that referenced
this pull request
Mar 18, 2015
Allow docker_container memory to have String value (eg. memory='1G').
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This very modest PR allows String values for docker_container memory attribute.
Currently, the docker_container resource only allows
Fixnumvalues for the attribute (in other words, memory value is implicitly in bytes) but the docker documentation says that thedocker run --memoryparameter supports optional units. It is also possible to specify different memory and memory+swap limits.With this PR I can set
docker.memory = '1G'ordocker.memory = '150m,200m', while still allowing for Fixnum memory values as before.