-
-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests #1245
Fix tests #1245
Conversation
Signed-off-by: Ben Dean <ben.dean@finvi.com>
Signed-off-by: Ben Dean <ben.dean@finvi.com>
Signed-off-by: Ben Dean <ben.dean@finvi.com>
Signed-off-by: Ben Dean <ben.dean@finvi.com>
a38b8a9
to
ef234ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, other than the lint-unit workflow changes this looks good.
…ef workstation version Signed-off-by: Ben Dean <ben.dean@finvi.com>
Signed-off-by: Ben Dean <ben.dean@finvi.com>
…it times out Signed-off-by: Ben Dean <ben.dean@finvi.com>
Sorry about all the force pushes over and over. I was trying to keep the changes related to fixing tests in here so #1246 was just changing things for Chef 18. If you tag a new version of sous-chefs/.github I'll commit again here, otherwise it should be good. |
this was merged as part of #1246 |
Description
There were a number of tests failing because of Chef 17 vs 18 or Docker version 24. I'm working on fixing another issue and thought I'd just make a PR with these changes.
Issues Resolved
Depends on sous-chefs/.github#25 being merged first if you don't want to refer to my branch.
Check List
## Unreleased