Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly install lxc on Ubuntu (fixes #101) #102

Merged
merged 1 commit into from
Mar 29, 2014
Merged

Explicitly install lxc on Ubuntu (fixes #101) #102

merged 1 commit into from
Mar 29, 2014

Conversation

carmstrong
Copy link
Contributor

See #101 and #100.

@bflad
Copy link
Contributor

bflad commented Mar 27, 2014

I'm going to disagree with adding this to package recipe here, but would temporarily accept adding this to the lxc recipe. I can do this later tonight if I don't see an update to this PR. Docker introduced native execution driver support in 0.9 and made it the default, even though LXC has been the Docker way since 0.1.

I already have issues (like #91 for lxc) to migrate non-native execution driver functionality from this cookbook into cookbooks that will manage them much better. Otherwise we'd potentially have to support installation and configuration for LXC, libvirt, and others.

@carmstrong
Copy link
Contributor Author

Agreed that it probably shouldn't be in the package recipe, at least without a conditional around it to check if lxc is indeed the exec_type. That was an oversight with my PR which I can fix.

However, the problem is that the lxc recipe is only included when the install_type != package, which it is by default. See: https://github.com/bflad/chef-docker/blob/master/recipes/default.rb#L14-L23

It actually looks like that's the fix - the docker::lxc recipe should indeed work, but it should be called outside the unless node['docker']['install_type'] == 'package' context.

@carmstrong
Copy link
Contributor Author

@bflad this new commit works on a test-kicthen run, although I don't fully appreciate the implications of moving the include before include_recipe "docker::#{node['docker']['storage_driver']}" if node['docker']['storage_driver'] -- is it necessary to include the storage driver recipe before this?

@bflad
Copy link
Contributor

bflad commented Mar 29, 2014

We should be okay with its new placement. Thanks!

bflad added a commit that referenced this pull request Mar 29, 2014
Explicitly install lxc on Ubuntu (fixes #101)
@bflad bflad merged commit 00fbd9e into sous-chefs:master Mar 29, 2014
@bflad
Copy link
Contributor

bflad commented Mar 29, 2014

@carmstrong
Copy link
Contributor Author

Thanks @bflad! When the next version is cut, we'll update our dependencies.

@carmstrong carmstrong deleted the install_lxc_on_ubuntu branch March 31, 2014 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants