Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: fix many minor documentation nits #2814

Merged
merged 1 commit into from
Oct 16, 2023
Merged

MRG: fix many minor documentation nits #2814

merged 1 commit into from
Oct 16, 2023

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Oct 16, 2023

Follow-up to #2184 with minor corrections.

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #2814 (eaefedf) into latest (0db31c8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           latest    #2814   +/-   ##
=======================================
  Coverage   86.27%   86.27%           
=======================================
  Files         130      130           
  Lines       14750    14750           
  Branches     2623     2623           
=======================================
  Hits        12725    12725           
  Misses       1724     1724           
  Partials      301      301           
Flag Coverage Δ
hypothesis-py 25.81% <ø> (ø)
python 92.85% <ø> (ø)
rust 50.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ctb
Copy link
Contributor Author

ctb commented Oct 16, 2023

@ccbaumler mind taking a quick look at the changes? thx!

@taylorreiter
Copy link
Contributor

Had a chance to look again -- love the simplified nav bar on the left. I can't find the generic dev docs anymore tho, can those be added back in or am I missing some context?

@ctb
Copy link
Contributor Author

ctb commented Oct 16, 2023

Had a chance to look again -- love the simplified nav bar on the left. I can't find the generic dev docs anymore tho, can those be added back in or am I missing some context?

Working on that over in #2811 - not quite ready yet, but mostly updated the structure. Comments welcome!

I may take your "had a chance to look at this PR" as an implicit endorsement of merging it, depending on whether I get any other feedback today ;)

Copy link
Contributor

@taylorreiter taylorreiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now it's explicit :)

@ctb ctb merged commit 009e462 into latest Oct 16, 2023
36 checks passed
@ctb ctb deleted the minor_doc_fixes branch October 16, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants