Fix docker base image for jupyter-caf-kernel #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
- Out of date and needing updates in general
Codecov Report
@@ Coverage Diff @@
## master #574 +/- ##
=======================================
Coverage 50.22% 50.22%
=======================================
Files 3 3
Lines 3044 3044
=======================================
Hits 1529 1529
Misses 1515 1515 |
- On macOS use the correct variable name. - Fix extra / in cmake PATH - Only add CMake to PATH if the directory isn't on the PATH already
|
I've bundled in some more bug fixes/feature requests:
@rouson a code review is welcome, but please don't merge, I'm going to merge on the command line, to help with pgp signing for a release. |
This was requested by a package maintainer.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixed the docker image that includes OpenCoarrays; docker hub builds were failing
Rationale for changes
Try to restore Jupyter-CAF-kernel to working order; this is the first step.
Additional info and certifications
This pull request (PR) is a:
I certify that
- Increasing test coverage for all feature-addition PRs
- Increasing test coverage for all bug-fix PRs for which there
does not already exist a related test that failed before the PR
- At least maintaining test coverage for all other PRs
- Ensuring that all tests pass when run locally
- Naming PR to indicate work in progress (WIP) and to attach the PR
to the appropriate bug report or feature request issue
- White space (no trailing white space or white space errors may
be introduced)
- Commenting code where it is non-obvious and non-trivial
- Logically atomic, self consistent and coherent commits
- Commit message content
- Waiting 24 hours before self-approving the PR to give another
OpenCoarrays developer a chance to review my proposed code