Vehre/async alloc comp support #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 49bf756)
libcaf.h/mpi_caf.c: ------------------- Changed the library API to needs of gcc-7 by adding the new constants for caf_register and caf_deregister. Changing the interface of caf_deregster to take the dereg mode and adding the prototype for caf_is_present(). The inquiry function caf_is_present() is available as protoype only and error stops as unimplemented when called. tests/unit/init_register/*rename_me*: ------------------------------------- Renaming to reasonable filename done. tests/unit/init_register/register_alloc_comp_[1-3].f90: ------------------------------------------------------- Testing that allocation of (scalar|vector|matrix) components works. src/tests/unit/init_register/check_remote_alloced_comp_1.f90: ------------------------------------------------------------- Testing that asynchronous allocation of scalar components works. The test fails/hangs for two reasons at the moment: 1. caf_register is not asynchronously allocation components, 2. caf_is_present is not implemented and is therefore deactivated in the testsection of the main CMakeLists.txt CMakeLists.txt: --------------- Added testcases. (cherry picked from commit e3dba75 and commit ca76a39, and then these two were squashed. All code done by Andre/@vehre and original commit messages tidied by @zbeekman)
Wrap build and add test commands with conditionals
Remove the sync_all from the `register()`, because the compiler now generates it after the assignment in an `ALLOCATE(, SOURCE=)` has been done. Comment on `MPI_Win_allocate()` implicitly synchronizing. (cherry picked from commit 7e917b2, minor wording changes to commit log from @zbeekman for clarity)
|
No objections here. Go for it. |
|
still looks good to me |
Current coverage is 50.38% (diff: 100%)@@ master #276 diff @@
==========================================
Files 2 2
Lines 909 909
Methods 42 42
Messages 0 0
Branches 195 195
==========================================
Hits 458 458
Misses 368 368
Partials 83 83
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes PR #261, #259
@afanfa signed off on #261 but I wanted to clean it up and add some conditionals around the tests requiring GCC 7 so that they don't get built.
src/tests/unit/init_register/check_remote_alloced_comp_1.f90is anticipated to fail when building with GCC 7 until #260 is finished