Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-standard abort() calls in tests #239

Closed
rouson opened this issue Nov 3, 2016 · 1 comment
Closed

Remove non-standard abort() calls in tests #239

rouson opened this issue Nov 3, 2016 · 1 comment

Comments

@rouson
Copy link
Member

rouson commented Nov 3, 2016

With the aim of making OpenCoarrays viable for use with multiple compilers, please ensure that all code that hits the master branch is standard-conforming. An example of non-standard code is the "call abort()" appearing throughout the test suite, including but definitely not limited to the following locations:

  1. Line 26 of get_with_offset_1d.f90.
  2. Line 45 and other lines in get_array_test.f90.
  3. Line 173 and other lines in old_get_array_test.f90.
  4. Line 133 of sameloc.f90.

and many other locations. Presumably these only terminate a single image and should therefore be replaced with stop. Alternatively, if global termination is intended, they should be replaced with error stop.

If there is a compelling reason to include non-standard code in the repository, let's document it. I will submit a separate issue to help address the state of documentation in the tests.

@rouson
Copy link
Member Author

rouson commented Nov 3, 2016

@vehre and @afanfa

Item 1 in the above list is the one current test failure when building OpenCoarrays with the GCC 7 trunk dated 20161026. GitHub shows the two of you as contributors to the relevant file: get_with_offset_1d.f90. Please address the above issue in that file and any others to which you contributed.

zbeekman added a commit that referenced this issue Nov 3, 2016
 Replace compiler extension `abort()` calls with standard Fortran `error
 stop` statements.

 Fixes #239
@ghost ghost assigned zbeekman Nov 3, 2016
@zbeekman zbeekman mentioned this issue Nov 3, 2016
@ghost ghost added the needs-review label Nov 3, 2016
@ghost ghost removed the needs-review label Nov 4, 2016
zbeekman added a commit that referenced this issue Nov 4, 2016
 Replace compiler extension `abort()` calls with standard Fortran `error
 stop` statements.

 Fixes #239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants