Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'sub-section' from source code #97

Closed
wants to merge 1 commit into from
Closed

Remove 'sub-section' from source code #97

wants to merge 1 commit into from

Conversation

alexeymalihin
Copy link

Checking if h3 is not is source_example.
Prevents adding sub navigation link if h3 is part of source code.

Checking if h3 is not is source_example.
Prevents adding sub navigation link if h3 is part of source code.
@robhrt7
Copy link
Member

robhrt7 commented Feb 10, 2015

Hi,

Thank you for noticing quite major bug. But lets do it simpler, just like that:

var subHeaders = section.children("h3");

Because we need only .section > h3

@alexeymalihin
Copy link
Author

Hi,

We couldn't have sub-sub-section? Like .section > h3 > h3? If no, than decline PR and fix it as you suggested please.

@robhrt7
Copy link
Member

robhrt7 commented Feb 22, 2015

We treat h4 as sub-section of h3, and all tags are on one level of HTML nesting. We will fix this issue in upcoming 0.4.1.

@robhrt7 robhrt7 closed this Feb 22, 2015
@robhrt7
Copy link
Member

robhrt7 commented Feb 22, 2015

45ea069

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants