Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate: no longer require SRC_GITHUB_TOKEN to be set #958

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

jdpleiness
Copy link
Contributor

Previously src validate install required the env var SRC_GITHUB_TOKEN to be set, even if no external services were being added. This also blocked validating queries with repositories that already existed on a Sourcegraph deployment.

This fix allows src validate install to be run without requiring the SRC_GITHUB_TOKEN env var to be set, as well as validating queries with repositories that already exist on a deployment.

Fixes #956
Fixes https://github.com/sourcegraph/sourcegraph/issues/47576

Test plan

Locally tested changes using latest Sourcegraph Helm install.

ran go test ./... - all tests passing
ran staticcheck ./... - no issues found in new code

@jdpleiness jdpleiness self-assigned this Mar 15, 2023
Copy link
Contributor

@scjohns scjohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I don't write Go code so would be great to have someone more familiar with the code give the approval

Copy link
Member

@eseliger eseliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did a quick glance, nothing stood out so let's go :)

@jdpleiness jdpleiness merged commit 0ce1ae4 into main Mar 16, 2023
@jdpleiness jdpleiness deleted the jdp/fix-src-github-token branch March 16, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants