Clean up volumes if workspace preparation fails #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eseliger
reviewed
Aug 21, 2023
Comment on lines
232
to
233
| _ = deleteVolume(ctx, w.volume) | ||
| return nil |
There was a problem hiding this comment.
Suggested change
| _ = deleteVolume(ctx, w.volume) | |
| return nil | |
| return deleteVolume(ctx, w.volume) |
To keep the error reporting
There was a problem hiding this comment.
D'oh, not sure how I misread the code. I'll fix.
There was a problem hiding this comment.
Fixed, thanks for pointing out!
lowjoel
force-pushed
the
cleanup-failed-prepared-workspaces
branch
from
24890ef
to
0172845
Compare
lowjoel
force-pushed
the
cleanup-failed-prepared-workspaces
branch
from
0172845
to
970f0d3
Compare
|
I also fixed the tests this round. Let me know what you think. |
BolajiOlajide
approved these changes
Aug 23, 2023
eseliger
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If workspace preparation fails, the temporary Docker volume is not cleaned up.
Test plan
I'll need help filling in this bit. Apart from manually inducing an error with the workspace process, how else? I could possibly build locally a broken batch-change container image that doesn't have Git nor unzip?