Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ALL imports of PropTypes #37

Merged
merged 1 commit into from
Jul 29, 2017

Conversation

sginn
Copy link
Contributor

@sginn sginn commented Jul 27, 2017

I updated to 0.62, and was still getting deprecation warnings in my console from MediaPlayer.
This changeset should address my exact scenario, and all other consumers.

lowPriorityWarning.js:40 Warning: Accessing PropTypes via the main React package is deprecated, and will be removed in React v16.0. Use the latest available v15.* prop-types package from npm instead. For info on usage, compatibility, migration and more, see https://fb.me/prop-types-docs
printWarning @ lowPriorityWarning.js:40
lowPriorityWarning @ lowPriorityWarning.js:59
get @ React.js:100
./node_modules/react-media-player/lib/Media.js @ Media.js:243
webpack_require @ bootstrap a1b5740…:659
fn @ bootstrap a1b5740…:85
./node_modules/react-media-player/lib/react-media-player.js @ react-media-player.js:8
webpack_require @ bootstrap a1b5740…:659
fn @ bootstrap a1b5740…:85
./src/components/main/messages/Messages/Chat/ChatMessage/Attachments/AudioPlayer.jsx @ AudioPlayer.css?40e8:26
webpack_require @ bootstrap a1b5740…:659
fn @ bootstrap a1b5740…:85

@souporserious
Copy link
Owner

Thank you 🙏

@souporserious souporserious merged commit 147fff5 into souporserious:master Jul 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants