Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins not added to sos.html #3780

Open
jpbruijstens opened this issue Sep 17, 2024 · 2 comments
Open

Plugins not added to sos.html #3780

jpbruijstens opened this issue Sep 17, 2024 · 2 comments

Comments

@jpbruijstens
Copy link

jpbruijstens commented Sep 17, 2024

When using sosreport version 4.5.6, all plugins are listed in sos.html as follows: <h2 id="tunnel">Plugin <em>tunnel</em></h2>

When using sosreport version 4.8.0, plugins are not listed in sos.html anymore.

@jcastill
Copy link
Member

Thank you for reporting this. Indeed there's a difference - this is what I have in 4.6.0:

<h2 id="alternatives">Plugin <em>alternatives</em></h2>
<p>Commands executed:</p><ul>
<li><a href="../sos_commands/alternatives/alternatives_--display_arptables">alternatives --display arptables</a></li>
<li><a href="../sos_commands/alternatives/alternatives_--display_cifs-idmap-plugin">alternatives --display cifs-idmap-plugin</a></li>
<li><a href="../sos_commands/alternatives/alternatives_--display_ebtables">alternatives --display ebtables</a></li>
<li><a href="../sos_commands/alternatives/alternatives_--display_iptables">alternatives --display iptables</a></li>
<li><a href="../sos_commands/alternatives/alternatives_--display_libnssckbi.so.x86_64">alternatives --display libnssckbi.so.x86_64</a></li>
<li><a href="../sos_commands/alternatives/alternatives_--display_man">alternatives --display man</a></li>
<li><a href="../sos_commands/alternatives/alternatives_--display_man.7.gz">alternatives --display man.7.gz</a></li>
<li><a href="../sos_commands/alternatives/alternatives_--display_nc">alternatives --display nc</a></li>
<li><a href="../sos_commands/alternatives/alternatives_--display_soelim">alternatives --display soelim</a></li>
<li><a href="../sos_commands/alternatives/alternatives_--list">alternatives --list</a></li>
<li><a href="../sos_commands/alternatives/alternatives_--version">alternatives --version</a></li>
</ul>
<hr/>

And this is what I have in 4.7.2:

alternatives
<p>Commands executed:</p><ul>
<li><a href="../sos_commands/alternatives/alternatives_--display_arptables">alternatives --display arptables</a></li>
<li><a href="../sos_commands/alternatives/alternatives_--display_cifs-idmap-plugin">alternatives --display cifs-idmap-plugin</a></li>
<li><a href="../sos_commands/alternatives/alternatives_--display_ebtables">alternatives --display ebtables</a></li>
<li><a href="../sos_commands/alternatives/alternatives_--display_iptables">alternatives --display iptables</a></li>
<li><a href="../sos_commands/alternatives/alternatives_--display_libnssckbi.so.x86_64">alternatives --display libnssckbi.so.x86_64</a></li>
<li><a href="../sos_commands/alternatives/alternatives_--display_man">alternatives --display man</a></li>
<li><a href="../sos_commands/alternatives/alternatives_--display_man.7.gz">alternatives --display man.7.gz</a></li>
<li><a href="../sos_commands/alternatives/alternatives_--display_nc">alternatives --display nc</a></li>
<li><a href="../sos_commands/alternatives/alternatives_--display_soelim">alternatives --display soelim</a></li>
<li><a href="../sos_commands/alternatives/alternatives_--list">alternatives --list</a></li>
<li><a href="../sos_commands/alternatives/alternatives_--version">alternatives --version</a></li>
</ul>
<hr/>

I'm checking the latest changes we've done to the HTML reporting, but if somebody else has an idea about what happened, please feel free to comment.

@jcastill
Copy link
Member

Issue was introduced in 57d2134. I'm working on a fix right now.

jcastill added a commit to jcastill/sos that referenced this issue Sep 17, 2024
After moving from .format() to f-strings via
57d2134, the formatting for Plugin sections was
lost. This patch attempts to fix this while still
using f-strings.

Related: sosreport#3780

Signed-off-by: Jose Castillo <jcastillo@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants