Changes to support acl-loader and mirror-session config commands for multi-npu platforms. #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
suggested changes
May 7, 2020
abdosi
force-pushed
the
multinpu-acl-uploader
branch
2 times, most recently
from
05dc81b
to
eba8329
Compare
abdosi
changed the title
jleveque
previously approved these changes
May 8, 2020
|
Retest this please |
judyjoseph
reviewed
May 8, 2020
judyjoseph
reviewed
May 8, 2020
judyjoseph
previously approved these changes
May 10, 2020
Move multi-npu related utility functions from config/main.py to sonic-device-util.py so that it can be used by acl-loader/any other module. Updated Mirror Session add/remove for multi-npu platforms. Needed for Everflow ACL rule programming.
daall
reviewed
May 11, 2020
except for doc string
abdosi
force-pushed
the
multinpu-acl-uploader
branch
from
eba8329
to
727e9e7
Compare
daall
approved these changes
May 12, 2020
|
@abdosi I would assume the CLI tests are failing because sonic-net/sonic-buildimage#4559 isn't merged yet, let's make sure that gets approved and merged first so we can confirm the utilities tests are working before merging this PR. |
@daall Yes this is dependent on sonic-net/sonic-buildimage#4559 and we will merge sonic-buildimage PR first and then this PR. After this will have another PR for sonic-utilities submodule update in sonic-buildimage |
jleveque
approved these changes
May 12, 2020
|
Retest this please |
|
retest this please |
1 similar comment
|
retest this please |
abdosi
added a commit
that referenced
this pull request
May 20, 2020
…multi-npu platforms. (#908) * Changes to support acl-loader command for multi-npu platforms. Move multi-npu related utility functions from config/main.py to sonic-device-util.py so that it can be used by acl-loader/any other module. Updated Mirror Session add/remove for multi-npu platforms. Needed for Everflow ACL rule programming. * Address review comment to change comment from """ to # except for doc string
abdosi
added a commit
to abdosi/sonic-utilities
that referenced
this pull request
Aug 4, 2020
…multi-npu platforms. (sonic-net#908) * Changes to support acl-loader command for multi-npu platforms. Move multi-npu related utility functions from config/main.py to sonic-device-util.py so that it can be used by acl-loader/any other module. Updated Mirror Session add/remove for multi-npu platforms. Needed for Everflow ACL rule programming. * Address review comment to change comment from """ to # except for doc string
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 18, 2022
Update submodule sonic-sairedis that contains the following commit: Change the log severity leve from ERROR to NOTICE if getStatus is not supported by vendor (sonic-net#908) (sonic-net#991)
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
[201911][show] Fix abbreviations for 'show ip bgp ...' commands (sonic-net#909) Changes to support acl-loader and mirror-session config commands for multi-npu platforms. (sonic-net#908) Changes to commands config reload/load-minigraph (sonic-net#919) Stop/Start restapi server upon config reload (sonic-net#911) [config] Add 'interface transceiver' subgroup with 'lpmode' and 'reset' subcommands (sonic-net#904)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Changes to support acl-loader and mirror session config commands for multi-npu platforms.
Also moved some of utility functions form config/main.py to sonic_device_util.py.
This PR is needed with:
sonic-net/sonic-buildimage#4559
- How I did it
updated the commands to check if multi-npu platform present then program per asic namespace also
- How to verify it
Verified for multi-npu platform