[202205][db_migrator] Add migration of FLEX_COUNTER_DELAY_STATUS during 1911->2205 upgrade + fast-reboot. Add UT. #2870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng 1911->2211 upgrade + fast-reboot. Add UT. Signed-off-by: vadymhlushko-mlnx <vadymh@nvidia.com>
vadymhlushko-mlnx
force-pushed
the
202205-flex-counter-delay-status-migration
branch
from
7390758
to
240ec23
Compare
|
@vaibhavhd @arfeigin could you please review the changes? |
vaibhavhd
approved these changes
Jun 15, 2023
|
I don't have permissions to merge to this branch. |
|
@yxieca can you please merge this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add migration of
FLEX_COUNTER_DELAY_STATUSattribute of config_dbFLEX_COUNTER_TABLEduring theSONiC to SONiC upgrade + fast-rebootfrom older versions201911 -> 202205.This change is required for the
fast-rebootprocedure because without it the counters will be created during the init flow which will waste a lot of resources and cause data plane degradation of more than 30 seconds.How I did it
Modify the
db_migrator.py.How to verify it
Add UT.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)