Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subinterface vrf bind issue fix #2211

Merged
merged 13 commits into from
Aug 29, 2022
Merged

Subinterface vrf bind issue fix #2211

merged 13 commits into from
Aug 29, 2022

Commits on Jul 26, 2022

  1. Add support to configure routed subinterface in short name and long name 

    format
Update "show subniterface status" to reflect subinterface in user
configured long name and short name format.
    @preetham-singh
    preetham-singh committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    b77a5a1 View commit details
    Browse the repository at this point in the history

  2. Fixing LGTM warnings

    @preetham-singh
    preetham-singh committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    40f3ae6 View commit details
    Browse the repository at this point in the history

  3. Updating Config guide with subinterface config & show commands.

    @preetham-singh
    preetham-singh committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    f612ef8 View commit details
    Browse the repository at this point in the history

  4. Using updated py common utility subintf apis and updating mock_tables

    @preetham-singh
    preetham-singh committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    5398047 View commit details
    Browse the repository at this point in the history

  5. Updating intfutil test cases for subinterfaces

    @preetham-singh
    preetham-singh committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    21dfe1e View commit details
    Browse the repository at this point in the history

  6. This commit addresses below issues: 

    1. Short Format Subinterface getting deleted after vrf binding . Issue
10802:sonic-net/sonic-buildimage#10802
2. Do not allow short format subinterface to be created without encap
vlan configuration. Issue 10878:
sonic-net/sonic-buildimage#10878
    @preetham-singh
    preetham-singh committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    db70036 View commit details
    Browse the repository at this point in the history

  7. This commit addresses below issues: 

    1. Short Format Subinterface getting deleted after vrf binding . Issue
10802:sonic-net/sonic-buildimage#10802
2. Do not allow short format subinterface to be created without encap
vlan configuration. Issue 10878:
sonic-net/sonic-buildimage#10878
    @preetham-singh
    preetham-singh committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    113d8c3 View commit details
    Browse the repository at this point in the history

  8. Subintf UT fixes

    @preetham-singh
    preetham-singh committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    4bbfa23 View commit details
    Browse the repository at this point in the history

  9. Updating Config vrf bind/unbind CLIs to skip deletion of subinterface 

    instead update existing subinterface.
Updating unit testcases for subinterfaces.
    @preetham-singh
    preetham-singh committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    7565284 View commit details
    Browse the repository at this point in the history

  10. Fixing rebase merge conflicts

    @preetham-singh
    preetham-singh committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    1face1e View commit details
    Browse the repository at this point in the history

  11. Addressing review comments

    @preetham-singh
    preetham-singh committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    c592983 View commit details
    Browse the repository at this point in the history

  12. Adding more UT for better code coverage

    @preetham-singh
    preetham-singh committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    219a53d View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2022

  1. Adding subintf vrf bind unbind click CLI tests

    @preetham-singh
    preetham-singh committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    e523615 View commit details
    Browse the repository at this point in the history