Add 'show' and 'clear' command for PG drop #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 2 alerts when merging 7ec47e2 into 4e27ad7 - view on LGTM.com new alerts:
|
|
Please add unit tests |
liat-grozovik
changed the title
|
@ayurkiv-nvda please add to the PR description the output of the show command as part of |
liat-grozovik
previously requested changes
Feb 28, 2021
fixed |
added |
Done |
|
This pull request introduces 1 alert when merging a2483a30c5c301e0f3799470431a969b7d9a441d into 8b3bc18 - view on LGTM.com new alerts:
|
neethajohn
reviewed
Mar 5, 2021
ayurkiv-nvda
force-pushed
the
pg_drop_show_clear
branch
from
a2483a3
to
d535878
Compare
ayurkiv-nvda
force-pushed
the
pg_drop_show_clear
branch
from
d535878
to
d007fbe
Compare
|
This pull request introduces 1 alert when merging d007fbe into 13ce4b6 - view on LGTM.com new alerts:
|
neethajohn
approved these changes
Mar 10, 2021
daall
pushed a commit
that referenced
this pull request
Mar 19, 2021
* What I did
Added new CLI commands to view and clear PG dropped packet statistics.
Added the new CLI commands to the command reference guide.
* How I did it
I have added script which can generate table that shows current PG dropped packet statistic and also can clean it
Clean and Show is implemented with using serialized stats from previous execution.
To calculate current stats we do next step:
- take old serialized data (if no 'clear' executed all serialized data is 0)
- take current stat
- show diff between current and old
* How to verify it
run
show priority-group drop counters - show current stat
sonic-clear priority-group drop counters - clear current stat
* New command output (if the output of a command-line utility has changed)
show priority-group drop counters
Ingress PG dropped packets:
Port PG0 PG1 PG2 PG3 PG4 PG5 PG6 PG7
--------- ----- ----- ----- ----- ----- ----- ----- -----
Ethernet0 800 801 802 803 804 805 806 807
Ethernet4 400 401 402 403 404 405 406 407
Ethernet8 100 101 102 103 104 105 106 107
...
sonic-clear priority-group drop counters
Cleared PG drop counters
Co-authored-by: ayurkiv <ayurkiv@contoso.com>
|
Need to put the newly added |
neethajohn
pushed a commit
that referenced
this pull request
Jun 22, 2022
…rpoll, show/clear counters) (#2155) Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com> Should be merged after sonic-net/sonic-swss#2263 Appropriate PR in master:#1355, #1461, #1583 What I did Added new option for "counterpoll" utility Added new CLI commands to view and clear PG dropped packet statistics. Added the new CLI commands to the command reference guide. How I did it Need to merge PG drop functionality to 201911 How to verify it admin@arc-switch1041:~$ counterpoll pg-drop enable --> to enable the new counter admin@arc-switch1041:~$ counterpoll show --> check new INGRESS_PG_STAT_DROP counter status Check counters admin@arc-switch1041:~$ redis-cli -n 2 127.0.0.1:6379[2]> HGETALL COUNTERS:oid:0x1a000000000062 1) "SAI_INGRESS_PRIORITY_GROUP_STAT_XOFF_ROOM_WATERMARK_BYTES" 2) "0" 3) "SAI_INGRESS_PRIORITY_GROUP_STAT_SHARED_WATERMARK_BYTES" 4) "0" 5) "SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS" 6) "0" show priority-group drop counters Ingress PG dropped packets: Port PG0 PG1 PG2 PG3 PG4 PG5 PG6 PG7 --------- ----- ----- ----- ----- ----- ----- ----- ----- Ethernet0 800 801 802 803 804 805 806 807 Ethernet4 400 401 402 403 404 405 406 407 Ethernet8 100 101 102 103 104 105 106 107 ... sonic-clear priority-group drop counters Cleared PG drop counters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added new CLI commands to view and clear PG dropped packet statistics.
Added the new CLI commands to the command reference guide.
- How I did it
I have added script which can generate table that shows current PG dropped packet statistic and also can clean it
Clean and Show is implemented with using serialized stats from previous execution.
To calculate current stats we do next step:
How to verify it
run
show priority-group drop counters - show current stat
sonic-clear priority-group drop counters - clear current stat
Previous command output (if the output of a command-line utility has changed)
N/A
New command output (if the output of a command-line utility has changed)
Cleared PG drop counters