Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kdump improvements #1284

Merged
merged 3 commits into from
Dec 4, 2020
Merged

Conversation

rajendra-dendukuri
Copy link
Contributor

  • Added support for reporting kdump reboot cause to detect and report
    a kernel crash
  • Added additional commands to sonic-kdump-config wrapper script to
    dump Kdump configuration and status information in JSON format
  • Automatically save Kdump configuration in startup configuration file.
    This is an added convenience to the user as Kdump configuration changes
    require a system reboot and user is expected to save the configuration so
    that they are activated post reboot.
  • Additional bug fixes and improvements to allow hostcfgd to process Kdump
    configuration changes in ConfigDB. sonic-kdump-config script will write to
    ConfigDB.
  • Moved kdump CLI commands to a dedicated file

Signed-off-by: Rajendra Dendukuri rajendra.dendukuri@broadcom.com

- What I did
Kdump CLI improvements and bug fixes

- How I did it

  • Added support for reporting kdump reboot cause to detect and report a kernel crash
  • Added additional commands to sonic-kdump-config wrapper script to dump Kdump configuration and status information in JSON format
  • Automatically save Kdump configuration in startup configuration file. This is an added convenience to the user as Kdump configuration changes require a system reboot and user is expected to save the configuration so that they are activated post reboot.
  • Additional bug fixes and improvements to allow hostcfgd to process Kdump configuration changes in ConfigDB. sonic-kdump-config script will write to ConfigDB.
  • Moved kdump CLI commands to a dedicated file

- How to verify it
config kdump enable
config kdump disable
config kdump memory
config kdump num-dumps
show kdump status
show reboot-cause

- Previous command output (if the output of a command-line utility has changed)

- New command output (if the output of a command-line utility has changed)

rajendra-dendukuri and others added 2 commits December 2, 2020 20:57
- Added support for reporting kdump reboot cause to detect and report
a kernel crash
- Added additional commands to sonic-kdump-config wrapper script to
dump Kdump configuration and status information in JSON format
- Automatically save Kdump configuration in startup configuration file.
This is an added convenience to the user as Kdump configuration changes
require a system reboot and user is expected to save the configuration so
that they are activated post reboot.
- Additional bug fixes and improvements to allow hostcfgd to process Kdump
configuration changes in ConfigDB. sonic-kdump-config script will write to
ConfigDB.
- Moved kdump CLI commands to a dedicated file

Signed-off-by: Rajendra Dendukuri <rajendra.dendukuri@broadcom.com>
@lgtm-com
Copy link

lgtm-com bot commented Dec 3, 2020

This pull request introduces 6 alerts when merging 4eb223d into 3749f5e - view on LGTM.com

new alerts:

  • 2 for Except block handles 'BaseException'
  • 2 for Variable defined multiple times
  • 1 for Testing equality to None
  • 1 for Syntax error

Signed-off-by: Rajendra Dendukuri <rajendra.dendukuri@broadcom.com>
@lguohan lguohan merged commit 042254e into sonic-net:master Dec 4, 2020
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
 [vnet] Fix IP2ME route creation logic for BITMAP VNET interface (sonic-net#1284)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants