Support building sonic-utilities as a Python wheel package instead of a Debian package #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 19, 2020
Update paths to reflect new sonic-utilities install location, /usr/local/bin/
sonic-net/sonic-ztp#19
Merged
Merged
lguohan
reviewed
Sep 19, 2020
| @@ -324,7 +324,7 @@ function reboot_pre_check() | |||
| fi | |||
|
|
|||
| # Make sure ASIC configuration has not changed between images | |||
| ASIC_CONFIG_CHECK_SCRIPT="/usr/bin/asic_config_check" | |||
| ASIC_CONFIG_CHECK_SCRIPT="/usr/local/bin/asic_config_check" | |||
There was a problem hiding this comment.
is it doable not to change the path?
There was a problem hiding this comment.
Unfortunately, no. Wheels install to /usr/local/bin, whereas .debs install to /usr/bin. There's no way to change this behavior.
jleveque
added a commit
to Azure/sonic-build-tools
that referenced
this pull request
Sep 19, 2020
Build sonic-utilities as a Python wheel instead of a Debian package to support sonic-net/sonic-utilities#1122
|
Retest this please |
1 similar comment
|
Retest this please |
lguohan
approved these changes
Sep 19, 2020
|
After reviewing the check build logs, it is apparent there is a chicken/egg problem, as the build copies artifacts from the last successful build of buildimage-vs-all. Therefore, the new sonic-utilities wheel package built here will not even get installed in the VS container before running the swss tests, making this test meaningless. I will merge this PR and update the submodule in sonic-net/sonic-buildimage#5409 and iterate on that PR if necessary. |
jleveque
added a commit
to sonic-net/sonic-ztp
that referenced
this pull request
Sep 19, 2020
…cal/bin/ (#19) Update paths to reflect new sonic-utilities install location. As of PR sonic-net/sonic-utilities#1122, sonic-utilities is built and installed as a Python Wheel package. As such, the installation directory of the scripts/entrypoints has changed from `/usr/bin/` to `/usr/local/bin`. This patch updates all references to the old location to either reference the new location, or remove the absolute path entirely, where applicable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Support building sonic-utilities as a Python wheel package rather than a Debian package.
Notes:
- How I did it
data_filessection from setup.py- How to verify it
Ensure all CLI-related functionality continues to work as expected
NOTE: PR tests will fail until the build job is updated to build as a Python wheel. PR here: Azure/sonic-build-tools#160