[201911][pfcwd] Avoid ingress drop by not attaching zero profiles when pfc storm is detected #2279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neetha John <nejo@microsoft.com>
neethajohn
changed the title
|
@vivekreddynv , please review as well. Not able to add you as a reviewer |
vivekrnv
reviewed
May 17, 2022
vivekrnv
approved these changes
May 17, 2022
stephenxs
reviewed
May 18, 2022
Signed-off-by: Neetha John <nejo@microsoft.com>
stephenxs
approved these changes
May 18, 2022
prsunny
approved these changes
May 18, 2022
neethajohn
added a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Jul 11, 2022
…on Rx (#5665) Signed-off-by: Neetha John <nejo@microsoft.com> For platforms that use the zero buffer detection logic for pfcwd, modify the testcase to check for ingress traffic getting forwarded. Related to sonic-net/sonic-swss#2279 How did you verify/test it? Ran the test with these changes on Mellanox platform and it passed
wangxin
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Jul 12, 2022
…on Rx (#5665) Signed-off-by: Neetha John <nejo@microsoft.com> For platforms that use the zero buffer detection logic for pfcwd, modify the testcase to check for ingress traffic getting forwarded. Related to sonic-net/sonic-swss#2279 How did you verify/test it? Ran the test with these changes on Mellanox platform and it passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Neetha John nejo@microsoft.com
What I did
According to the current pfcwd detection logic on certain platforms, when wd fires, we create an ingress zero pool, ingress zero profile, egress zero pool, egress zero profile (if not already created) and then attach the ingress zero profile to the ingress pg and egress zero profile to the egress queue. As a result traffic ingressing that port/pg and egressing that port/queue will get dropped.
The current changes are done to avoid dropping traffic that is ingressing the port/pg that is in storm. The code changes in this PR avoid creating the ingress zero pool and profile and not attach any zero profile to the ingress pg when pfcwd is triggered
How I verified it
Modified the pfcwd func tests (sonic-net/sonic-mgmt#5665) and testcase passed on Mellanox platform
Details if related