Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle dual ToR neighbor miss scenario #2137

Merged

Commits on Feb 8, 2022

  1. [neighsyncd]: Support dualtor neighbor miss

    - If unable to resolve a neighbor on a dual ToR system, write a neighbor table entry for that neighbor with a zero MAC
    
    Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
    theasianpianist committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    3a1805d View commit details
    Browse the repository at this point in the history
  2. [orchagent]: Support dualtor neighbor miss

    - When receiving a neighbor update with a zero MAC:
        - If the neighbor IP is configured for a specific mux cable port in the MUX_CABLE table in CONFIG_DB, handle the neighbor normally (if active for the port, no action is needed. if standby, a tunnel route is created for the neighbor IP)
        - If the neighbor IP is not configured for a specific port, create a tunnel route for the IP to the peer switch.
            - When these neighbor IPs are eventually resolved, remove the tunnel route and handle the neighbor normally.
    
    Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
    theasianpianist committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    f925ba7 View commit details
    Browse the repository at this point in the history
  3. [neighorch]: Remove duplicate neighbor entry

    Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
    theasianpianist committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    e6869f4 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2022

  1. [swss]: Address review comments

    - Insert newline before open braces
    - Use MacAddress boolean conversion
    
    Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
    theasianpianist committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    549e891 View commit details
    Browse the repository at this point in the history
  2. Add VS test

    Sumukha Tumkur Vani authored and theasianpianist committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    11f9589 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2022

  1. [neighsyncd]: Handle dual ToR neighbor deletion

    Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
    theasianpianist committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    7f4b0e9 View commit details
    Browse the repository at this point in the history
  2. [neighorch]: Reduce zero mac tunnel log level

    Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
    theasianpianist committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    fb01e0c View commit details
    Browse the repository at this point in the history
  3. [muxorch]: Handle standalone tunnel neighbors

    - Move standalone tunnel neighbor handling to completely separate code path
    
    Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
    theasianpianist committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    5ff5dd7 View commit details
    Browse the repository at this point in the history
  4. [tests]: Update fixture declarations

    Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
    theasianpianist committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    1feea32 View commit details
    Browse the repository at this point in the history
  5. [test_mux]: Dual ToR neighbor miss test scenarios

    - Add dual ToR neighbor miss test cases:
        - Create generic test runner function that executes test
          steps described in mux_neigh_miss_tests.py
        - Add neighbor miss test case with missing PEER_SWITCH config
    - Create setup fixtures for dual ToR DB entries
        - CONFIG_DB: VLAN, MUX_CABLE, PEER_SWITCH
        - APPL_DB: TUNNEL_DECAP_TABLE
    - Refactor existing tests to use setup fixtures for consistency
    - Create ASIC_DB and APPL_DB verification functions
        - Verify APPL_DB NEIGH_TABLE entry presence/absence
        - Verify ASIC_DB ROUTE_ENTRY and NEIGH_ENTRY entry presence/absence
    - Create various fixtures to generate test information
    
    Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
    theasianpianist committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    7a0c3e7 View commit details
    Browse the repository at this point in the history
  6. [test_mux]: Formatting fixes

    Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
    theasianpianist committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    193a00d View commit details
    Browse the repository at this point in the history
  7. [tests]: Address lgtm

    Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
    theasianpianist committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    dc04459 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2022

  1. [neighorch]: Remove unused include and define

    Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
    theasianpianist committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    499475e View commit details
    Browse the repository at this point in the history