[teammgrd]: Create unique LACP key for port-channel #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
/AzurePipelines run |
|
Commenter does not have sufficient privileges for PR 1660 in repo Azure/sonic-swss |
DavidZagury
force-pushed
the
unique_lacp_key_bug_4009
branch
3 times, most recently
from
29fe875
to
33d2483
Compare
lguohan
reviewed
Mar 5, 2021
lguohan
reviewed
Mar 5, 2021
|
@lguohan - please keep in mind that the fix for this issue (#4009) arrive with this PR and additional PR: |
|
thank you. commented on 1473 pr. |
judyjoseph
reviewed
Mar 6, 2021
judyjoseph
reviewed
Mar 6, 2021
DavidZagury
force-pushed
the
unique_lacp_key_bug_4009
branch
4 times, most recently
from
b3a3868
to
1f7a4fa
Compare
liat-grozovik
changed the title
|
@ judyjoseph any comments on this PR? can you please explain why the recent mentioned PR is related and how you would like to move forward with this one? |
lguohan
reviewed
Mar 16, 2021
lguohan
reviewed
Mar 16, 2021
|
i have concerns on the sleeps in the test, code looks good to me. please add yang model as well in sonic-buildimage repo. |
DavidZagury
force-pushed
the
unique_lacp_key_bug_4009
branch
from
1f7a4fa
to
83f5ca9
Compare
Closed
4 tasks
DavidZagury
force-pushed
the
unique_lacp_key_bug_4009
branch
from
83f5ca9
to
92ed8ca
Compare
Merged
4 tasks
DavidZagury
force-pushed
the
unique_lacp_key_bug_4009
branch
from
92ed8ca
to
06bfed4
Compare
judyjoseph
approved these changes
Apr 26, 2021
|
@lguohan any further feedback? |
|
this looks like a new feature, not sure why needs backport. |
lguohan
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
May 7, 2021
) To update the yang model to support the new key interduced in sonic-net/sonic-swss#1660
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
…nic-net#7297) To update the yang model to support the new key interduced in sonic-net/sonic-swss#1660
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…nic-net#7297) To update the yang model to support the new key interduced in sonic-net/sonic-swss#1660
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
Fix issue - sonic-net/sonic-buildimage#4009 When a member port is added to port-channel, create a unique LACP key. When adding a member port to port-channel set the LACP key to a unique number. The number is extracted from the port-channel name and will be the number at the end of the port-channel name with an additional digit at the beginning in order to make sure that this number will be unique in the system. Why I did it If LACP key is not set, then the peer will not be able to distinguish the ports which are connected to different port-channels, as it will receive the LACP key as 0 for all the ports from different port-channels. How I verified it I configure a SONiC switch to have two port-channels and on a second switch, I created one port-channel for both links between the switches. On the second switch only one of the ports comes up in the PO and the other one stayed down.
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…anox switches (sonic-net#1660) - What I did Enhance the way techsupport collects dumps provided by SAI and do not keep them in the filesystem once the techsupport is created. - How I did it Create a temporary directory once techsupport script is executed, gather all files SAI dumps created, add them to the tech support and remove the temporary directory and files. Remove direct call to FW trace collection as it is done now by SAI dump - How to verify it Run techsupport, verify newly created files are part of it including mlxtrace which is no longer called directly by the techsupport script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix sonic-net/sonic-buildimage#4009
When a member port is added to port-channel, create a unique LACP key.
When adding a member port to port-channel set the LACP key to a unique number.
The number is extracted from the port-channel name and will be the number at the end of the port-channel name with an additional digit at the beginning in order to make sure that this number will be unique in the system.
Why I did it
If LACP key is not set, then the peer will not be able to distinguish the ports which are connected to different port-channels, as it will receive the LACP key as 0 for all the ports from different port-channels.
How I verified it
I configure a SONiC switch to have two port-channels and on a second switch, I created one port-channel for both links between the switches.
On the second switch only one of the ports comes up in the PO and the other one stayed down.
Which release branch to backport (provide reason below if selected)