[Multi-AISC] Pass the asic instance as SAI attribute during switch_create #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rchagent to accept the instance ID which is fills in HARDWARE_INFO and passes to switch create.
lguohan
reviewed
Apr 23, 2020
lguohan
reviewed
Apr 23, 2020
lguohan
approved these changes
Apr 23, 2020
rlhui
pushed a commit
that referenced
this pull request
Apr 30, 2020
…eate (#1269) * SAI 3.7 Supports multiple ASIC instances. This change is needed for orchagent to accept the instance ID which is fills in HARDWARE_INFO and passes to switch create. * Update the usage help string with the new option [-i INST_ID]
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…c-net#1269) **- What I did** When adding or deleting an DHCP relay destination address to a VLAN, previously, the service was simply restarted. However, we have set a start limit on services in SONiC, such that if a service is restarted X times within Y time, the service will enter a failed state and cannot be started until the failed state is cleared (currently 3 times within 20 minutes). However, if someone attempts to perform more than 3 add or delete operations within 20 minutes, it would trigger this failure condition. This change prevents this form occurring. **- How I did it** Rather than simply calling `systemctl restart dhcp_relay` after adding or deleting a DHCP relay destination IP address, we now call: ``` systemctl stop dhcp_relay systemctl reset-failed dhcp_relay systemctl start dhcp_relay ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added the new option [-i INST_ID] in orchagent to get the asic instance id passed by user and populate it in SAI_SWITCH_ATTR_SWITCH_HARDWARE_INFO during create_switch().
Why I did it
In multi-ASIC platforms the create_switch API should inform the syncd/SAI/SDK the particular ASIC instance to be initialized and controller by this orchagent.
How I verified it
Verified on a multi-ASIC and single ASIC devices the orchagent/syncd is up interfaces in good state.
Need additional change in the file sonic-buildimage/dockers/docker-orchagent/orchagent.sh to pass the instance ID with -i option.
Details if related