[counter] Fix port flex counter #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prgeor
previously approved these changes
Jun 3, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kcudnik
reviewed
Jun 8, 2022
syncd/FlexCounter.cpp
Outdated
| @@ -2437,7 +2431,7 @@ void FlexCounter::endFlexCounterThread(void) | |||
| } | |||
|
|
|||
| sai_status_t FlexCounter::querySupportedPortCounters( | |||
| _In_ sai_object_id_t portRid) | |||
| _In_ sai_object_id_t portRid, _Out_ PortCountersSet &supportedPortCounters) | |||
kcudnik
approved these changes
Jun 9, 2022
yxieca
pushed a commit
that referenced
this pull request
Jun 9, 2022
Fix sonic-net/sonic-buildimage#10850. A fact is there might be different port types on asic, then different port stats capabilities. Instead of using a cached supported port counter ID list for all ports, it gets supported port counter list per port.
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
Fix sonic-net/sonic-buildimage#10850. A fact is there might be different port types on asic, then different port stats capabilities. Instead of using a cached supported port counter ID list for all ports, it gets supported port counter list per port.
skbarista
pushed a commit
to skbarista/sonic-sairedis
that referenced
this pull request
Dec 2, 2022
Fix sonic-net/sonic-buildimage#10850. A fact is there might be different port types on asic, then different port stats capabilities. Instead of using a cached supported port counter ID list for all ports, it gets supported port counter list per port.
lukasstockner
pushed a commit
to genesiscloud/sonic-sairedis
that referenced
this pull request
Mar 31, 2023
Fix sonic-net/sonic-buildimage#10850. A fact is there might be different port types on asic, then different port stats capabilities. Instead of using a cached supported port counter ID list for all ports, it gets supported port counter list per port.
lukasstockner
pushed a commit
to genesiscloud/sonic-sairedis
that referenced
this pull request
Mar 31, 2023
Fix sonic-net/sonic-buildimage#10850. A fact is there might be different port types on asic, then different port stats capabilities. Instead of using a cached supported port counter ID list for all ports, it gets supported port counter list per port.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix sonic-net/sonic-buildimage#10850.
A fact is there might be different port types on asic, then different port stats capabilities. Instead of using a cached supported port counter ID list for all ports, it gets supported port counter list per port.