[Multiasic]: Add calculation of interface index for backplane interfaces #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
interfaces in multi asic platform. Multiasic platform will have backplane interface names of the format Ethernet-BP<x>. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
qiluo-msft
reviewed
Apr 28, 2020
| @@ -6,19 +6,22 @@ | |||
|
|
|||
|
|
|||
| SONIC_ETHERNET_RE_PATTERN = "^Ethernet(\d+)$" | |||
| SONIC_ETHERNET_BP_RE_PATTERN = "^Ethernet-BP(\d+)$" | |||
There was a problem hiding this comment.
BP [](start = 42, length = 2)
Explain in comment what is BP? #Closed
There was a problem hiding this comment.
added as per comment
qiluo-msft
reviewed
Apr 28, 2020
| SONIC_PORTCHANNEL_RE_PATTERN = "^PortChannel(\d+)$" | ||
| SONIC_MGMT_PORT_RE_PATTERN = "^eth(\d+)$" | ||
|
|
||
|
|
||
| class BaseIdx: | ||
| ethernet_base_idx = 1 | ||
| ethernet_bp_base_idx = 9000 |
There was a problem hiding this comment.
9000 [](start = 27, length = 4)
How do you choose this value? Is 2000 working? #Closed
There was a problem hiding this comment.
There was a problem hiding this comment.
Chose 9000 as the offset will be large enough and Index does not overlap.
With 2000 as offset, it might overlap with PortChannel interface index.
There was a problem hiding this comment.
@qiluo-msft , i think 9000 should be a good safe offset value for back-plane instead of a lower value
Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
qiluo-msft
approved these changes
Apr 29, 2020
prsunny
approved these changes
Apr 29, 2020
lguohan
approved these changes
May 5, 2020
abdosi
pushed a commit
that referenced
this pull request
May 5, 2020
…ces (#68) * [Multiasic]: Add calculation of infterface index for backplane interfaces in multi asic platform. Multiasic platform will have backplane interface names of the format Ethernet-BP<x>. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com> * Added comment. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
praveen-li
pushed a commit
to praveen-li/sonic-py-swsssdk
that referenced
this pull request
May 4, 2021
…ces (sonic-net#68) * [Multiasic]: Add calculation of infterface index for backplane interfaces in multi asic platform. Multiasic platform will have backplane interface names of the format Ethernet-BP<x>. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com> * Added comment. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add calculation of interface index for backplane interfaces
in multi asic platform. Multiasic platform will have
backplane interface names of the format Ethernet-BP.
Signed-off-by: SuvarnaMeenakshi sumeenak@microsoft.com