Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kvm] Re-enable test_po_update for KVM test #2408

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

daall
Copy link
Contributor

@daall daall commented Oct 26, 2020

Signed-off-by: Danny Allen daall@microsoft.com

Description of PR

Summary: [kvm] Re-enable test_po_update for KVM test
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

We previously disabled po_update for KVM because it was flaky. This flakiness was addressed in sonic-net/sonic-swss#1462 so we can re-enable it.

How did you do it?

Added the test to the run list.

How did you verify/test it?

Re-ran test locally multiple times.

Any platform specific information?

KVM

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: Danny Allen <daall@microsoft.com>
@daall
Copy link
Contributor Author

daall commented Oct 26, 2020

retest vsimage please

1 similar comment
@daall
Copy link
Contributor Author

daall commented Oct 26, 2020

retest vsimage please

@daall
Copy link
Contributor Author

daall commented Oct 27, 2020

retest vsimage please (one more time to make sure the test is really stable :))

@daall
Copy link
Contributor Author

daall commented Oct 27, 2020

tlm_teamd has a chance to crash during the test it looks like, so this PR depends on sonic-net/sonic-buildimage#5719

@lguohan
Copy link
Contributor

lguohan commented Oct 29, 2020

seems like vsimage build was not successful to pick up that change yet.

@daall
Copy link
Contributor Author

daall commented Oct 29, 2020

seems like vsimage build was not successful to pick up that change yet.

If everything goes well, https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/buildimage-vs-image/531/ should have it here in 20-30mins

@lguohan
Copy link
Contributor

lguohan commented Oct 29, 2020

hmm, i am not that optimistic, it seems there are multiple image issues that is causing the vs test failing.

@daall
Copy link
Contributor Author

daall commented Oct 29, 2020

retest vsimage please

@daall
Copy link
Contributor Author

daall commented Oct 29, 2020

hmm, i am not that optimistic, it seems there are multiple image issues that is causing the vs test failing.

It looks like there is another issue w/ tlm_teamd, I'll take a look

@lguohan
Copy link
Contributor

lguohan commented Oct 30, 2020

opened an issue here. sonic-net/sonic-buildimage#5755

assigned to @pavel-shirshov to take a look

@yxieca
Copy link
Collaborator

yxieca commented Oct 30, 2020

retest vsiamge please

@yxieca
Copy link
Collaborator

yxieca commented Oct 30, 2020

retest vsimage please

@daall
Copy link
Contributor Author

daall commented Nov 2, 2020

@daall
Copy link
Contributor Author

daall commented Nov 4, 2020

retest this please

@daall
Copy link
Contributor Author

daall commented Nov 5, 2020

retest this please (1 more time to verify the tlm_teamd crash is gone)

@daall daall merged commit e77b443 into sonic-net:master Nov 5, 2020
@daall daall deleted the enable_po_update branch November 5, 2020 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants