Keep incrementing sequence number when link prober is suspended and shutdown #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yxieca
approved these changes
Apr 1, 2022
|
This commit could not be cleanly cherry-picked to 202012. Please submit another PR. |
This was referenced Apr 11, 2022
zjswhhh
added a commit
that referenced
this pull request
Apr 15, 2022
…hutdown #55 (#65) ### Description of PR Unable to cherry-pick the commit below cleanly from master branch: 13f4879 Jing Zhang Sun Apr 3 21:56:33 2022 -0700 Keep incrementing sequence number when link prober is suspended and shutdown (#55) Summary: Fixes # (issue) This PR is fix the issue when both sides' link prober is suspended, LinkManager still appears to be healthy. When HB suspends, TX sequence number is not updated either, hence link prober won't post an `unknown` event. sign-off: Jing Zhang zhangjing@microsoft.com ### Type of change - [x] Bug fix ### Approach #### What is the motivation for this PR? Make sure link prober is reporting `unknown` event when it's suspended or shutdown on both sides. #### How did you do it? Increment sequence number even when HB is not sent. #### How did you verify/test it? Tested on dualToR testbed.
zjswhhh
added a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Apr 17, 2022
[master][sonic-linkmgrd] submodule updates 41f5fb9 Jing Zhang Mon Apr 11 08:33:39 2022 -0700 Upgrade linkmgrd to `BULLSEYE` (sonic-net/sonic-linkmgrd#60) 2fc890e Jing Zhang Mon Apr 4 10:25:22 2022 -0700 Lower unsolicited MUX state change notification log level to WARNING (sonic-net/sonic-linkmgrd#57) 13f4879 Jing Zhang Sun Apr 3 21:56:33 2022 -0700 Keep incrementing sequence number when link prober is suspended and shutdown (sonic-net/sonic-linkmgrd#55) 62482e1 Jing Zhang Sun Apr 3 20:54:40 2022 -0700 Reset link prober state when default route is back (sonic-net/sonic-linkmgrd#56) 34a68d1 Jing Zhang Thu Mar 31 18:33:46 2022 -0700 disable switchover measuring based on link prober (sonic-net/sonic-linkmgrd#49) 898a655 Jing Zhang Thu Mar 31 15:42:15 2022 -0700 Update link prober metrics posting logics (sonic-net/sonic-linkmgrd#50) sign-off: Jing Zhang zhangjing@microsoft.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
This PR is fix the issue when both sides' link prober is suspended, LinkManager still appears to be healthy.
When HB suspends, TX sequence number is not updated either, hence link prober won't post an
unknownevent.sign-off: Jing Zhang zhangjing@microsoft.com
Type of change
Approach
What is the motivation for this PR?
Make sure link prober is reporting
unknownevent when it's suspended or shutdown on both sides.How did you do it?
Increment sequence number even when HB is not sent.
How did you verify/test it?
Tested on dualToR testbed.
Any platform specific information?
Documentation