[NTP] Update NTP configuration via ConfigDB #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests will fail until sonic-net/sonic-swss-common#781 will be merged |
This was referenced May 13, 2023
fastiuk
force-pushed
the
dev-ntp-configuration
branch
3 times, most recently
from
64d4f01
to
e46a3aa
Compare
fastiuk
force-pushed
the
dev-ntp-configuration
branch
from
e46a3aa
to
8141e90
Compare
saiarcot895
reviewed
Jul 3, 2023
scripts/hostcfgd
Outdated
| """ | ||
| NTP_CONF_RESTART = ['service', 'ntp-config', 'restart'] |
There was a problem hiding this comment.
Why is service being used instead of systemctl?
There was a problem hiding this comment.
No special reason. Both will work equally.
There was a problem hiding this comment.
Regardless, I think systemctl should be used instead of service here, since the systemctl command is already used in many other places, and this would keep things consistent.
Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>
Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>
fastiuk
force-pushed
the
dev-ntp-configuration
branch
from
8141e90
to
c2a05e8
Compare
saiarcot895
approved these changes
Sep 18, 2023
|
/azpw run sonic-host-services |
1 similar comment
|
/azpw run sonic-host-services |
|
/AzurePipelines run sonic-host-services |
|
No pipelines are associated with this pull request. |
qiluo-msft
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Dec 11, 2023
hld [#1296](sonic-net/SONiC#1296) closes [#1254](sonic-net/SONiC#1254) depends-on [#60](sonic-net/sonic-host-services#60), [#781](sonic-net/sonic-swss-common#781), [#2835](sonic-net/sonic-utilities#2835), [#10749](sonic-net/sonic-mgmt#10749) #### Why I did it To cover the next AIs: * Configure NTP global parameters * Add/remove new NTP servers * Change the configuration for NTP servers * Show NTP status * Show NTP configuration ### How I did it * Add YANG model for a new configuration * Extend configuration templates to support new knobs ### Description for the changelog * Add ability to configure NTP global parameters such as authentication, dhcp, admin state * Change the configuration for NTP servers * Add an ability to show NTP configuration #### Link to config_db schema for YANG module changes [NTP configuration](https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md#ntp-and-syslog-servers)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hld #1219
closes #1171
This PR brings functionality that allows us to update the NTP configs by writing to the NTP, NTP_SERVER, and NTP_KEY tables of ConfigDB.