SONiC Yang model for sFlow feature #7473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ArthiSivanantham <arthi_sivanantham@dell.com>
ArthiSivanantham
force-pushed
the
sonic_yangs
branch
from
a846127
to
cff757c
Compare
|
@lguohan, @praveen-li - Can you please review this PR ? |
Signed-off-by: ArthiSivanantham <arthi_sivanantham@dell.com>
ArthiSivanantham
force-pushed
the
sonic_yangs
branch
from
cff757c
to
3c4c20e
Compare
|
@lguohan, @praveen-li - Can you please review this PR ? |
venkatmahalingam
previously approved these changes
May 6, 2021
|
@anshuv-mfst - Can you please add the project as yang for this PR ? |
Signed-off-by: ArthiSivanantham <arthi_sivanantham@dell.com>
rathnasabapathyv
previously approved these changes
May 15, 2021
venkatmahalingam
previously approved these changes
May 15, 2021
|
@lguohan - Can you please check on this failure ?
|
|
Hi @renukamanavalan - could you please review. |
dgsudharsan
suggested changes
May 20, 2021
venkatmahalingam
previously approved these changes
Jun 21, 2021
dgsudharsan
previously approved these changes
Jun 21, 2021
Signed-off-by: Arthi Sivanantham <arthi_sivanantham@dell.com>
ArthiSivanantham
dismissed stale reviews from dgsudharsan and venkatmahalingam
via
9a1a068
venkatmahalingam
previously approved these changes
Jun 22, 2021
rathnasabapathyv
previously approved these changes
Jun 22, 2021
|
@dgsudharsan - Can you please review/approve ? |
|
@lguohan - Can you please merge this one ? |
dgsudharsan
previously approved these changes
Jun 29, 2021
praveen-li
reviewed
Jun 29, 2021
src/sonic-yang-models/tests/yang_model_tests/tests_config/sflow.json
Outdated
Show resolved
Hide resolved
Signed-off-by: Arthi Sivanantham <arthi_sivanantham@dell.com>
ArthiSivanantham
dismissed stale reviews from dgsudharsan, rathnasabapathyv, and venkatmahalingam
via
6487d32
|
All review comments are addressed. |
dgsudharsan
approved these changes
Jul 6, 2021
venkatmahalingam
approved these changes
Jul 6, 2021
rathnasabapathyv
approved these changes
Jul 6, 2021
|
@lguohan - Could you please merge this PR ? |
|
@lguohan - Can you please merge this PR ? |
|
Hi @renukamanavalan or @prsunny - could you please help with merge, thanks. |
prsunny
approved these changes
Aug 6, 2021
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
* SONiC YANG model support for sFlow feature. Signed-off-by: Arthi Sivanantham <arthi_sivanantham@dell.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ArthiSivanantham arthi_sivanantham@dell.com
Why I did it
SONiC YANG model support for sFlow feature.
How I did it
Defined various sFlow YANG containers and lists based on config-DB schema.
How to verify it
Successful build of the following packages:
make target/python-wheels/sonic_yang_models-1.0-py3-none-any.whl
make target/python-wheels/sonic_yang_mgmt-1.0-py3-none-any.whl
Which release branch to backport (provide reason below if selected)
Description for the changelog
SONiC Yang model support for sFlow feature.