Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[install.sh] Fix CPU cstates configuration #7222

Merged
merged 1 commit into from
Apr 4, 2021

Conversation

nazariig
Copy link
Collaborator

@nazariig nazariig commented Apr 2, 2021

Signed-off-by: Nazarii Hnydyn nazariig@nvidia.com

The motivation of these changes is to fix (#6051):

root@sonic:/home/admin# sonic_installer install sonic-mellanox.bin
New image will be installed, continue? [y/N]: y
Installing image SONiC-OS-SONIC.202012.50-50e4cc15 and setting it as default...
Command: ./sonic-mellanox.bin
/tmp/tmp.jLYyWStLHy/installer/install.sh: 547: /tmp/tmp.jLYyWStLHy/installer/install.sh: [[: not found

Why I did it

  • To fix CPU cstates configuration

How I did it

  • Updated code to be POSIX compatible

How to verify it

  1. root@sonic:/home/admin# sonic_installer install sonic-mellanox.bin

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Description for the changelog

  • N/A

A picture of a cute animal (not mandatory but encouraged)

      .---.        .-----------
     /     \  __  /    ------
    / /     \(  )/    -----
   //////   ' \/ `   ---
  //// / // :    : ---
 // /   /  /`    '--
//          //..\\
       ====UU====UU====
           '//||\\`
             ''``

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@nazariig
Copy link
Collaborator Author

nazariig commented Apr 2, 2021

@shlomibitton FYI

@liat-grozovik liat-grozovik merged commit 01b0330 into sonic-net:master Apr 4, 2021
@liat-grozovik
Copy link
Collaborator

@nazariig do we need the fix for 201911 as well? is this PR can be cherry picked to 201911 or need to have a new one against 201911?

@nazariig
Copy link
Collaborator Author

nazariig commented Apr 5, 2021

@nazariig do we need the fix for 201911 as well? is this PR can be cherry picked to 201911 or need to have a new one against 201911?

yes, we do need to cherry-pick to 201911 as well

daall pushed a commit that referenced this pull request Apr 5, 2021
The motivation of these changes is to fix (#6051):

- Why I did it
To fix CPU cstates configuration

- How I did it
Updated code to be POSIX compatible

- How to verify it
root@sonic:/home/admin# sonic_installer install sonic-mellanox.bin

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
abdosi pushed a commit that referenced this pull request Apr 8, 2021
The motivation of these changes is to fix (#6051):

- Why I did it
To fix CPU cstates configuration

- How I did it
Updated code to be POSIX compatible

- How to verify it
root@sonic:/home/admin# sonic_installer install sonic-mellanox.bin

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request May 23, 2021
The motivation of these changes is to fix (sonic-net#6051):

- Why I did it
To fix CPU cstates configuration

- How I did it
Updated code to be POSIX compatible

- How to verify it
root@sonic:/home/admin# sonic_installer install sonic-mellanox.bin

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
The motivation of these changes is to fix (sonic-net#6051):

- Why I did it
To fix CPU cstates configuration

- How I did it
Updated code to be POSIX compatible

- How to verify it
root@sonic:/home/admin# sonic_installer install sonic-mellanox.bin

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants