-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[install.sh] Fix CPU cstates configuration #7222
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@shlomibitton FYI |
lguohan
approved these changes
Apr 2, 2021
liat-grozovik
approved these changes
Apr 4, 2021
@nazariig do we need the fix for 201911 as well? is this PR can be cherry picked to 201911 or need to have a new one against 201911? |
yes, we do need to cherry-pick to |
daall
pushed a commit
that referenced
this pull request
Apr 5, 2021
The motivation of these changes is to fix (#6051): - Why I did it To fix CPU cstates configuration - How I did it Updated code to be POSIX compatible - How to verify it root@sonic:/home/admin# sonic_installer install sonic-mellanox.bin Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
abdosi
pushed a commit
that referenced
this pull request
Apr 8, 2021
The motivation of these changes is to fix (#6051): - Why I did it To fix CPU cstates configuration - How I did it Updated code to be POSIX compatible - How to verify it root@sonic:/home/admin# sonic_installer install sonic-mellanox.bin Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
The motivation of these changes is to fix (sonic-net#6051): - Why I did it To fix CPU cstates configuration - How I did it Updated code to be POSIX compatible - How to verify it root@sonic:/home/admin# sonic_installer install sonic-mellanox.bin Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
The motivation of these changes is to fix (sonic-net#6051): - Why I did it To fix CPU cstates configuration - How I did it Updated code to be POSIX compatible - How to verify it root@sonic:/home/admin# sonic_installer install sonic-mellanox.bin Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nazarii Hnydyn nazariig@nvidia.com
The motivation of these changes is to fix (#6051):
root@sonic:/home/admin# sonic_installer install sonic-mellanox.bin New image will be installed, continue? [y/N]: y Installing image SONiC-OS-SONIC.202012.50-50e4cc15 and setting it as default... Command: ./sonic-mellanox.bin /tmp/tmp.jLYyWStLHy/installer/install.sh: 547: /tmp/tmp.jLYyWStLHy/installer/install.sh: [[: not found
Why I did it
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)