Remove BRCM SAI Deb Kernel version dependency + Bypass PEER_MODE p2mp setting causing SYNCd crash on non-TD3 SKUs #6620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… setting syncd crash on non-TD3 SKUs
lguohan
approved these changes
Jan 31, 2021
deran1980
pushed a commit
to deran1980/sonic-buildimage
that referenced
this pull request
Feb 4, 2021
1. BRCM SAI Debian build need not have any Kernel version dependency - Starting with 4.3 BRCM made changes in SAI so that this dependency has been cleaned up. We can now remove the Kernel Version dependency from Azure Pipeline build script. 2. Bypass PEER_MODE p2mp setting causing SYNCd crash on non-TD3 SKUs - Temporarily patch BRCM SAI code to not cause SYNCd crash when Orchagent program SAI_TUNNEL_ATTR_PEER_MODE: SAI_TUNNEL_PEER_MODE_P2MP on Non-TD3 SKUs. Will remove this when BRCM provide proper fix to address this issue.
daall
pushed a commit
that referenced
this pull request
Feb 6, 2021
1. BRCM SAI Debian build need not have any Kernel version dependency - Starting with 4.3 BRCM made changes in SAI so that this dependency has been cleaned up. We can now remove the Kernel Version dependency from Azure Pipeline build script. 2. Bypass PEER_MODE p2mp setting causing SYNCd crash on non-TD3 SKUs - Temporarily patch BRCM SAI code to not cause SYNCd crash when Orchagent program SAI_TUNNEL_ATTR_PEER_MODE: SAI_TUNNEL_PEER_MODE_P2MP on Non-TD3 SKUs. Will remove this when BRCM provide proper fix to address this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
- How to verify it
Item 1: Attempt the new SAI Debian build with Kernel version dependency removed from build script and verified successful Debian built and it can be used to bring up BRCM DUT without any issue.
Item 2: Load current 4.3 image to a TH based SKU and run "vxlan/test_vxlan_decap.py" to validate that SYNCd crash is observed. After applying this fix re-ran the same test case and it is able to complete the test without causing SYNCd to crash. Though the test passed partially but the failure is no longer due to SYNCd issue any more.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
Remove BRCM SAI Deb Kernel version dependency + Bypass PEER_MODE p2mp setting causing SYNCd crash on non-TD3 SKUs