[barefoot] Fixes for platform API #6487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonina Melnyk antoninax.melnyk@intel.com
|
retest this please |
jleveque
approved these changes
Jan 21, 2021
|
Retest vsimage please |
lguohan
pushed a commit
that referenced
this pull request
Jan 25, 2021
There was a mismatch with Eeprom class methods names and methods called from Eeprom class. Signed-off-by: Antonina Melnyk antoninax.melnyk@intel.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Antonina Melnyk antoninax.melnyk@intel.com
- Why I did it
There was a mismatch with Eeprom class methods names and methods called from Eeprom class.
- How I did it
Renamed methods properly and added missing ones.
- How to verify it
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)