-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pcie.yaml] Move pcie configuration file path to platform directory #6475
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make PR title more descriptive.
Also, this PR removes the systemd timer file, but there is no mention of that in the PR description. Please also enhance the PR description to detail all changes in the PR.
can you have good description and pr title? |
@jleveque can you hold your review for now, I'm verifying the changes with pmon and utilities prs again. |
@sujinmkang: Once all of the related PRs for this change eventually merge, please be sure to update https://github.com/Azure/SONiC/wiki/Porting-Guide to reflect the path changes. |
…ded to multi-user.target to start during the boot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
retest vsimage please |
@jleveque is the PR title still not clear? |
The title and description are much better now. Thanks! |
/Azurepipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
there is a mistake here. /x86_64-cel_e1031-r0pcie.yaml |
@sujinmkang , can you fix? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix typo
@lguohan can you please review this again? |
I already addressed his review comment but didn't get any response for long days.
/Azurepipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
…6475) - Why I did it The pcie configuration file location is under plugin directory not under platform directory. #6437 - How I did it Move all pcie.yaml configuration file from plugin to platform directory. Remove unnecessary timer to start pcie-check.service Move pcie-check.service to sonic-host-services - How to verify it Verify on the device
…onic-net#6475) - Why I did it The pcie configuration file location is under plugin directory not under platform directory. sonic-net#6437 - How I did it Move all pcie.yaml configuration file from plugin to platform directory. Remove unnecessary timer to start pcie-check.service Move pcie-check.service to sonic-host-services - How to verify it Verify on the device
…onic-net#6475) - Why I did it The pcie configuration file location is under plugin directory not under platform directory. sonic-net#6437 - How I did it Move all pcie.yaml configuration file from plugin to platform directory. Remove unnecessary timer to start pcie-check.service Move pcie-check.service to sonic-host-services - How to verify it Verify on the device
- Why I did it
The pcie configuration file location is under plugin directory not under platform directory.
#6437
- How I did it
- How to verify it
Verify on the device.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)