Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[syncd-rpc docker] Fix issue: ptf_nn_agent isn't able to start in syncd-rpc docker on buster #6448

Merged
merged 4 commits into from
Jan 31, 2021

Conversation

stephenxs
Copy link
Collaborator

@stephenxs stephenxs commented Jan 14, 2021

- Why I did it
Fix issue: ptf_nn_agent isn't able to start in syncd-rpc docker on buster.

- How I did it
The issue is fixed by installing python-dev, cffi and nnpy for python 2 explicitly.

- How to verify it
Run copp test on RPC image.

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

liat-grozovik
liat-grozovik previously approved these changes Jan 17, 2021
@liat-grozovik
Copy link
Collaborator

retest vsimage please

@stephenxs stephenxs changed the title [Mellanox] Fix issue: ptf_nn_agent isn't able to start in syncd-rpc docker on buster [syncd-rpc docker] Fix issue: ptf_nn_agent isn't able to start in syncd-rpc docker on buster Jan 21, 2021
@stephenxs
Copy link
Collaborator Author

retest this please

@lguohan
Copy link
Collaborator

lguohan commented Jan 28, 2021

docker-syncd-bfn
docker-syncd-centec

are also buster baed.

- Install nanomsg related package by pip2 because
  1. the pip is for python-3 by default
  2. but ptf which is necessary isn't available for python 3
- Install python-setuptools

Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
…ased syncd docker

Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs
Copy link
Collaborator Author

docker-syncd-bfn
docker-syncd-centec

are also buster baed.

Indeed. These platforms were updated just after I had forked the branch of this PR.
I rebased and add them. Now, in the following platforms, syncd rpc image are buster based:

  • Mellanox
  • Broadcom
  • Barefoot
  • Centec and Centec arm64

@liat-grozovik liat-grozovik merged commit 4f50658 into sonic-net:master Jan 31, 2021
lguohan pushed a commit that referenced this pull request Feb 3, 2021
…cd-rpc docker on buster (#6448)

- Why I did it
Fix issue: ptf_nn_agent isn't able to start in syncd-rpc docker on buster.

- How I did it
The issue is fixed by installing python-dev, cffi and nnpy for python 2 explicitly.

- How to verify it
Run copp test on RPC image.
deran1980 pushed a commit to deran1980/sonic-buildimage that referenced this pull request Feb 4, 2021
…cd-rpc docker on buster (sonic-net#6448)

- Why I did it
Fix issue: ptf_nn_agent isn't able to start in syncd-rpc docker on buster.

- How I did it
The issue is fixed by installing python-dev, cffi and nnpy for python 2 explicitly.

- How to verify it
Run copp test on RPC image.
@stephenxs stephenxs deleted the mlnx-syncd-rpc branch March 31, 2021 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants